Skip to content

Commit 5f3e73f

Browse files
committed
Auto merge of #137754 - ChrisDenton:downgrade-sdk, r=<try>
[do not merge] fix 32-bit MSVC CI [alt version] r? `@ghost` try-job: i686-msvc-2
2 parents f45d4ac + 5e58769 commit 5f3e73f

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

.github/workflows/ci.yml

+15
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,21 @@ jobs:
174174
- name: ensure the stable version number is correct
175175
run: src/ci/scripts/verify-stable-version-number.sh
176176

177+
# Temporary fix to unblock CI
178+
# We revert to an older Windows SDK for 32-bit Windows MSVC builds.
179+
# See issue https://github.com/rust-lang/rust/issues/137733 for more details.
180+
- name: Downgrade Windows SDK
181+
shell: pwsh
182+
if: ${{ matrix.name == 'i686-msvc-1' || matrix.name == 'i686-msvc-2' || matrix.name == 'dist-i686-msvc' }}
183+
run: |
184+
$vs = &"${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -format value -property installationPath
185+
&$vs\Common7\Tools\Launch-VsDevShell.ps1 -HostArch Amd64 -Arch x86
186+
Enter-VsDevshell -VsInstallPath $vs -HostArch Amd64 -Arch x86 -DevCmdArguments "-winsdk 10.0.26100.0"
187+
$new_env = ls env: | foreach { echo "$($_.key)=$($_.value)" }
188+
$new_env >> $env:GITHUB_ENV
189+
$env:PATH += ";c:/msys64/usr/bin"
190+
$env:PATH >> $env:GITHUB_PATH
191+
177192
# Show the environment just before we run the build
178193
# This makes it easier to diagnose problems with the above install scripts.
179194
- name: show the current environment

src/ci/github-actions/jobs.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -474,13 +474,13 @@ auto:
474474
env:
475475
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-msvc --enable-sanitizers
476476
SCRIPT: make ci-msvc-py
477-
<<: *job-windows-8c
477+
<<: *job-windows
478478

479479
- name: i686-msvc-2
480480
env:
481481
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-msvc --enable-sanitizers
482482
SCRIPT: make ci-msvc-ps1
483-
<<: *job-windows-8c
483+
<<: *job-windows
484484

485485
# x86_64-msvc-ext is split into multiple jobs to run tests in parallel.
486486
- name: x86_64-msvc-ext1
@@ -595,7 +595,7 @@ auto:
595595
SCRIPT: python x.py dist bootstrap --include-default-paths
596596
DIST_REQUIRE_ALL_TOOLS: 1
597597
CODEGEN_BACKENDS: llvm,cranelift
598-
<<: *job-windows-8c
598+
<<: *job-windows
599599

600600
- name: dist-aarch64-msvc
601601
env:

0 commit comments

Comments
 (0)