Skip to content

Commit 6ae5106

Browse files
author
Keegan McAllister
committed
Use path helper macros in deriving
1 parent 2c05354 commit 6ae5106

File tree

13 files changed

+38
-28
lines changed

13 files changed

+38
-28
lines changed

‎src/libsyntax/ext/deriving/clone.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ pub fn expand_deriving_clone<F>(cx: &mut ExtCtxt,
2929
let trait_def = TraitDef {
3030
span: span,
3131
attributes: Vec::new(),
32-
path: Path::new(vec!("std", "clone", "Clone")),
32+
path: path!(std::clone::Clone),
3333
additional_bounds: Vec::new(),
3434
generics: LifetimeBounds::empty(),
3535
methods: vec!(

‎src/libsyntax/ext/deriving/cmp/eq.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ pub fn expand_deriving_eq<F>(cx: &mut ExtCtxt,
7070
generics: LifetimeBounds::empty(),
7171
explicit_self: borrowed_explicit_self(),
7272
args: vec!(borrowed_self()),
73-
ret_ty: Literal(Path::new(vec!("bool"))),
73+
ret_ty: Literal(path!(bool)),
7474
attributes: attrs,
7575
combine_substructure: combine_substructure(box |a, b, c| {
7676
$f(a, b, c)
@@ -82,7 +82,7 @@ pub fn expand_deriving_eq<F>(cx: &mut ExtCtxt,
8282
let trait_def = TraitDef {
8383
span: span,
8484
attributes: Vec::new(),
85-
path: Path::new(vec!("std", "cmp", "PartialEq")),
85+
path: path!(std::cmp::PartialEq),
8686
additional_bounds: Vec::new(),
8787
generics: LifetimeBounds::empty(),
8888
methods: vec!(

‎src/libsyntax/ext/deriving/cmp/ord.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ pub fn expand_deriving_ord<F>(cx: &mut ExtCtxt,
3636
generics: LifetimeBounds::empty(),
3737
explicit_self: borrowed_explicit_self(),
3838
args: vec!(borrowed_self()),
39-
ret_ty: Literal(Path::new(vec!("bool"))),
39+
ret_ty: Literal(path!(bool)),
4040
attributes: attrs,
4141
combine_substructure: combine_substructure(box |cx, span, substr| {
4242
cs_op($op, $equal, cx, span, substr)
@@ -45,8 +45,8 @@ pub fn expand_deriving_ord<F>(cx: &mut ExtCtxt,
4545
} }
4646
}
4747

48-
let ordering_ty = Literal(Path::new(vec!["std", "cmp", "Ordering"]));
49-
let ret_ty = Literal(Path::new_(vec!["std", "option", "Option"],
48+
let ordering_ty = Literal(path!(std::cmp::Ordering));
49+
let ret_ty = Literal(Path::new_(pathvec!(std::option::Option),
5050
None,
5151
vec![box ordering_ty],
5252
true));
@@ -69,7 +69,7 @@ pub fn expand_deriving_ord<F>(cx: &mut ExtCtxt,
6969
let trait_def = TraitDef {
7070
span: span,
7171
attributes: vec![],
72-
path: Path::new(vec!["std", "cmp", "PartialOrd"]),
72+
path: path!(std::cmp::PartialOrd),
7373
additional_bounds: vec![],
7474
generics: LifetimeBounds::empty(),
7575
methods: vec![

‎src/libsyntax/ext/deriving/cmp/totaleq.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ pub fn expand_deriving_totaleq<F>(cx: &mut ExtCtxt,
4646
let trait_def = TraitDef {
4747
span: span,
4848
attributes: Vec::new(),
49-
path: Path::new(vec!("std", "cmp", "Eq")),
49+
path: path!(std::cmp::Eq),
5050
additional_bounds: Vec::new(),
5151
generics: LifetimeBounds::empty(),
5252
methods: vec!(

‎src/libsyntax/ext/deriving/cmp/totalord.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ pub fn expand_deriving_totalord<F>(cx: &mut ExtCtxt,
3030
let trait_def = TraitDef {
3131
span: span,
3232
attributes: Vec::new(),
33-
path: Path::new(vec!("std", "cmp", "Ord")),
33+
path: path!(std::cmp::Ord),
3434
additional_bounds: Vec::new(),
3535
generics: LifetimeBounds::empty(),
3636
methods: vec!(
@@ -39,7 +39,7 @@ pub fn expand_deriving_totalord<F>(cx: &mut ExtCtxt,
3939
generics: LifetimeBounds::empty(),
4040
explicit_self: borrowed_explicit_self(),
4141
args: vec!(borrowed_self()),
42-
ret_ty: Literal(Path::new(vec!("std", "cmp", "Ordering"))),
42+
ret_ty: Literal(path!(std::cmp::Ordering)),
4343
attributes: attrs,
4444
combine_substructure: combine_substructure(box |a, b, c| {
4545
cs_cmp(a, b, c)

‎src/libsyntax/ext/deriving/decodable.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ fn expand_deriving_decodable_imp<F>(cx: &mut ExtCtxt,
6868
args: vec!(Ptr(box Literal(Path::new_local("__D")),
6969
Borrowed(None, MutMutable))),
7070
ret_ty: Literal(Path::new_(
71-
vec!("std", "result", "Result"),
71+
pathvec!(std::result::Result),
7272
None,
7373
vec!(box Self, box Literal(Path::new_(
7474
vec!["__D", "Error"], None, vec![], false

‎src/libsyntax/ext/deriving/default.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ pub fn expand_deriving_default<F>(cx: &mut ExtCtxt,
2929
let trait_def = TraitDef {
3030
span: span,
3131
attributes: Vec::new(),
32-
path: Path::new(vec!("std", "default", "Default")),
32+
path: path!(std::default::Default),
3333
additional_bounds: Vec::new(),
3434
generics: LifetimeBounds::empty(),
3535
methods: vec!(

‎src/libsyntax/ext/deriving/encodable.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ fn expand_deriving_encodable_imp<F>(cx: &mut ExtCtxt,
144144
args: vec!(Ptr(box Literal(Path::new_local("__S")),
145145
Borrowed(None, MutMutable))),
146146
ret_ty: Literal(Path::new_(
147-
vec!("std", "result", "Result"),
147+
pathvec!(std::result::Result),
148148
None,
149149
vec!(box Tuple(Vec::new()), box Literal(Path::new_(
150150
vec!["__S", "Error"], None, vec![], false

‎src/libsyntax/ext/deriving/hash.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ pub fn expand_deriving_hash<F>(cx: &mut ExtCtxt,
2525
F: FnOnce(P<Item>),
2626
{
2727

28-
let path = Path::new_(vec!("std", "hash", "Hash"), None,
28+
let path = Path::new_(pathvec!(std::hash::Hash), None,
2929
vec!(box Literal(Path::new_local("__S"))), true);
3030
let generics = LifetimeBounds {
3131
lifetimes: Vec::new(),
3232
bounds: vec!(("__S",
33-
vec!(Path::new(vec!("std", "hash", "Writer")),
34-
Path::new(vec!("std", "hash", "Hasher"))))),
33+
vec!(path!(std::hash::Writer),
34+
path!(std::hash::Hasher)))),
3535
};
3636
let args = Path::new_local("__S");
3737
let inline = cx.meta_word(span, InternedString::new("inline"));

‎src/libsyntax/ext/deriving/mod.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,18 @@ use ext::base::ExtCtxt;
1818
use codemap::Span;
1919
use ptr::P;
2020

21+
macro_rules! pathvec {
22+
($($x:ident)::+) => (
23+
vec![ $( stringify!($x) ),+ ]
24+
)
25+
}
26+
27+
macro_rules! path {
28+
($($x:tt)*) => (
29+
::ext::deriving::generic::ty::Path::new( pathvec!( $($x)* ) )
30+
)
31+
}
32+
2133
pub mod bounds;
2234
pub mod clone;
2335
pub mod encodable;

‎src/libsyntax/ext/deriving/primitive.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,16 @@ pub fn expand_deriving_from_primitive<F>(cx: &mut ExtCtxt,
3030
let trait_def = TraitDef {
3131
span: span,
3232
attributes: Vec::new(),
33-
path: Path::new(vec!("std", "num", "FromPrimitive")),
33+
path: path!(std::num::FromPrimitive),
3434
additional_bounds: Vec::new(),
3535
generics: LifetimeBounds::empty(),
3636
methods: vec!(
3737
MethodDef {
3838
name: "from_i64",
3939
generics: LifetimeBounds::empty(),
4040
explicit_self: None,
41-
args: vec!(
42-
Literal(Path::new(vec!("i64")))),
43-
ret_ty: Literal(Path::new_(vec!("std", "option", "Option"),
41+
args: vec!(Literal(path!(i64))),
42+
ret_ty: Literal(Path::new_(pathvec!(std::option::Option),
4443
None,
4544
vec!(box Self),
4645
true)),
@@ -54,9 +53,8 @@ pub fn expand_deriving_from_primitive<F>(cx: &mut ExtCtxt,
5453
name: "from_u64",
5554
generics: LifetimeBounds::empty(),
5655
explicit_self: None,
57-
args: vec!(
58-
Literal(Path::new(vec!("u64")))),
59-
ret_ty: Literal(Path::new_(vec!("std", "option", "Option"),
56+
args: vec!(Literal(path!(u64))),
57+
ret_ty: Literal(Path::new_(pathvec!(std::option::Option),
6058
None,
6159
vec!(box Self),
6260
true)),

‎src/libsyntax/ext/deriving/rand.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ pub fn expand_deriving_rand<F>(cx: &mut ExtCtxt,
3131
let trait_def = TraitDef {
3232
span: span,
3333
attributes: Vec::new(),
34-
path: Path::new(vec!("std", "rand", "Rand")),
34+
path: path!(std::rand::Rand),
3535
additional_bounds: Vec::new(),
3636
generics: LifetimeBounds::empty(),
3737
methods: vec!(
@@ -40,7 +40,7 @@ pub fn expand_deriving_rand<F>(cx: &mut ExtCtxt,
4040
generics: LifetimeBounds {
4141
lifetimes: Vec::new(),
4242
bounds: vec!(("R",
43-
vec!( Path::new(vec!("std", "rand", "Rng")) )))
43+
vec!( path!(std::rand::Rng) ))),
4444
},
4545
explicit_self: None,
4646
args: vec!(

‎src/libsyntax/ext/deriving/show.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ pub fn expand_deriving_show<F>(cx: &mut ExtCtxt,
2929
F: FnOnce(P<Item>),
3030
{
3131
// &mut ::std::fmt::Formatter
32-
let fmtr = Ptr(box Literal(Path::new(vec!("std", "fmt", "Formatter"))),
32+
let fmtr = Ptr(box Literal(path!(std::fmt::Formatter)),
3333
Borrowed(None, ast::MutMutable));
3434

3535
let trait_def = TraitDef {
3636
span: span,
3737
attributes: Vec::new(),
38-
path: Path::new(vec!["std", "fmt", "Debug"]),
38+
path: path!(std::fmt::Debug),
3939
additional_bounds: Vec::new(),
4040
generics: LifetimeBounds::empty(),
4141
methods: vec![
@@ -44,7 +44,7 @@ pub fn expand_deriving_show<F>(cx: &mut ExtCtxt,
4444
generics: LifetimeBounds::empty(),
4545
explicit_self: borrowed_explicit_self(),
4646
args: vec!(fmtr),
47-
ret_ty: Literal(Path::new(vec!("std", "fmt", "Result"))),
47+
ret_ty: Literal(path!(std::fmt::Result)),
4848
attributes: Vec::new(),
4949
combine_substructure: combine_substructure(box |a, b, c| {
5050
show_substructure(a, b, c)

0 commit comments

Comments
 (0)