Skip to content

Commit 6e5e97f

Browse files
committed
auto merge of #7028 : thestinger/rust/cmp, r=brson
2 parents 9bcf911 + 86833ea commit 6e5e97f

File tree

3 files changed

+23
-55
lines changed

3 files changed

+23
-55
lines changed

src/libextra/priority_queue.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -186,13 +186,12 @@ impl<T:Ord> PriorityQueue<T> {
186186
#[cfg(test)]
187187
mod tests {
188188
use sort::merge_sort;
189-
use core::cmp::le;
190189
use priority_queue::PriorityQueue;
191190

192191
#[test]
193192
fn test_top_and_pop() {
194-
let data = ~[2, 4, 6, 2, 1, 8, 10, 3, 5, 7, 0, 9, 1];
195-
let mut sorted = merge_sort(data, le);
193+
let data = ~[2u, 4, 6, 2, 1, 8, 10, 3, 5, 7, 0, 9, 1];
194+
let mut sorted = merge_sort(data, |x, y| x.le(y));
196195
let mut heap = PriorityQueue::from_vec(data);
197196
while !heap.is_empty() {
198197
assert_eq!(heap.top(), sorted.last());
@@ -274,8 +273,9 @@ mod tests {
274273

275274
fn check_to_vec(data: ~[int]) {
276275
let heap = PriorityQueue::from_vec(copy data);
277-
assert_eq!(merge_sort((copy heap).to_vec(), le), merge_sort(data, le));
278-
assert_eq!(heap.to_sorted_vec(), merge_sort(data, le));
276+
assert_eq!(merge_sort((copy heap).to_vec(), |x, y| x.le(y)),
277+
merge_sort(data, |x, y| x.le(y)));
278+
assert_eq!(heap.to_sorted_vec(), merge_sort(data, |x, y| x.le(y)));
279279
}
280280

281281
#[test]

src/libextra/time.rs

+18-20
Original file line numberDiff line numberDiff line change
@@ -1229,36 +1229,34 @@ mod tests {
12291229
}
12301230

12311231
fn test_timespec_eq_ord() {
1232-
use core::cmp::{eq, ge, gt, le, lt, ne};
1233-
12341232
let a = &Timespec::new(-2, 1);
12351233
let b = &Timespec::new(-1, 2);
12361234
let c = &Timespec::new(1, 2);
12371235
let d = &Timespec::new(2, 1);
12381236
let e = &Timespec::new(2, 1);
12391237

1240-
assert!(eq(d, e));
1241-
assert!(ne(c, e));
1238+
assert!(d.eq(e));
1239+
assert!(c.ne(e));
12421240

1243-
assert!(lt(a, b));
1244-
assert!(lt(b, c));
1245-
assert!(lt(c, d));
1241+
assert!(a.lt(b));
1242+
assert!(b.lt(c));
1243+
assert!(c.lt(d));
12461244

1247-
assert!(le(a, b));
1248-
assert!(le(b, c));
1249-
assert!(le(c, d));
1250-
assert!(le(d, e));
1251-
assert!(le(e, d));
1245+
assert!(a.le(b));
1246+
assert!(b.le(c));
1247+
assert!(c.le(d));
1248+
assert!(d.le(e));
1249+
assert!(e.le(d));
12521250

1253-
assert!(ge(b, a));
1254-
assert!(ge(c, b));
1255-
assert!(ge(d, c));
1256-
assert!(ge(e, d));
1257-
assert!(ge(d, e));
1251+
assert!(b.ge(a));
1252+
assert!(c.ge(b));
1253+
assert!(d.ge(c));
1254+
assert!(e.ge(d));
1255+
assert!(d.ge(e));
12581256

1259-
assert!(gt(b, a));
1260-
assert!(gt(c, b));
1261-
assert!(gt(d, c));
1257+
assert!(b.gt(a));
1258+
assert!(c.gt(b));
1259+
assert!(d.gt(c));
12621260
}
12631261

12641262
#[test]

src/libstd/cmp.rs

-30
Original file line numberDiff line numberDiff line change
@@ -172,36 +172,6 @@ pub trait Ord {
172172
fn gt(&self, other: &Self) -> bool;
173173
}
174174

175-
#[inline(always)]
176-
pub fn lt<T:Ord>(v1: &T, v2: &T) -> bool {
177-
(*v1).lt(v2)
178-
}
179-
180-
#[inline(always)]
181-
pub fn le<T:Ord>(v1: &T, v2: &T) -> bool {
182-
(*v1).le(v2)
183-
}
184-
185-
#[inline(always)]
186-
pub fn eq<T:Eq>(v1: &T, v2: &T) -> bool {
187-
(*v1).eq(v2)
188-
}
189-
190-
#[inline(always)]
191-
pub fn ne<T:Eq>(v1: &T, v2: &T) -> bool {
192-
(*v1).ne(v2)
193-
}
194-
195-
#[inline(always)]
196-
pub fn ge<T:Ord>(v1: &T, v2: &T) -> bool {
197-
(*v1).ge(v2)
198-
}
199-
200-
#[inline(always)]
201-
pub fn gt<T:Ord>(v1: &T, v2: &T) -> bool {
202-
(*v1).gt(v2)
203-
}
204-
205175
/// The equivalence relation. Two values may be equivalent even if they are
206176
/// of different types. The most common use case for this relation is
207177
/// container types; e.g. it is often desirable to be able to use `&str`

0 commit comments

Comments
 (0)