Skip to content

Commit 71c88e7

Browse files
committed
Fix infinite loop in BufReader::read_until.
1 parent e9c539a commit 71c88e7

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/libstd/io/mem.rs

+9-1
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,11 @@ impl<'a> Seek for BufReader<'a> {
312312

313313
impl<'a> Buffer for BufReader<'a> {
314314
fn fill<'a>(&'a mut self) -> IoResult<&'a [u8]> {
315-
Ok(self.buf.slice_from(self.pos))
315+
if self.pos < self.buf.len() {
316+
Ok(self.buf.slice_from(self.pos))
317+
} else {
318+
Err(io::standard_error(io::EndOfFile))
319+
}
316320
}
317321
fn consume(&mut self, amt: uint) { self.pos += amt; }
318322
}
@@ -449,6 +453,10 @@ mod test {
449453
assert_eq!(reader.read(buf), Ok(3));
450454
assert_eq!(buf.slice(0, 3), [5, 6, 7]);
451455
assert!(reader.read(buf).is_err());
456+
let mut reader = BufReader::new(in_buf);
457+
assert_eq!(reader.read_until(3).unwrap(), ~[0, 1, 2, 3]);
458+
assert_eq!(reader.read_until(3).unwrap(), ~[4, 5, 6, 7]);
459+
assert!(reader.read(buf).is_err());
452460
}
453461

454462
#[test]

0 commit comments

Comments
 (0)