Skip to content

Commit 81ea72b

Browse files
authored
Rollup merge of #103129 - notriddle:notriddle/sub-logo-container, r=GuillaumeGomez
rustdoc: remove unused `.sub-logo-container` DOM on non-source pages
2 parents 9a615fd + bcf4cfe commit 81ea72b

File tree

4 files changed

+8
-16
lines changed

4 files changed

+8
-16
lines changed

src/librustdoc/html/static/css/rustdoc.css

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -372,15 +372,11 @@ img {
372372
}
373373

374374
.sub-logo-container {
375-
display: none;
376-
margin-right: 20px;
377-
}
378-
379-
.source .sub-logo-container {
380375
display: block;
376+
margin-right: 20px;
381377
}
382378

383-
.source .sub-logo-container > img {
379+
.sub-logo-container > img {
384380
height: 60px;
385381
width: 60px;
386382
object-fit: contain;
@@ -1716,12 +1712,6 @@ in storage.js plus the media query with (max-width: 700px)
17161712
margin-top: 16px;
17171713
}
17181714

1719-
/* When we expand the sidebar on the source code page, we hide the logo on the left of the
1720-
search bar to have more space. */
1721-
.source-sidebar-expanded .source .sidebar + main .width-limiter .sub-logo-container.rust-logo {
1722-
display: none;
1723-
}
1724-
17251715
.source-sidebar-expanded .source .sidebar {
17261716
width: 300px;
17271717
}
@@ -2025,7 +2015,7 @@ in storage.js plus the media query with (min-width: 701px)
20252015
align-self: center;
20262016
}
20272017

2028-
.source .sub-logo-container > img {
2018+
.sub-logo-container > img {
20292019
height: 35px;
20302020
width: 35px;
20312021
}

src/librustdoc/html/templates/page.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,15 @@ <h2 class="location"></h2> {#- -#}
103103
<main> {#- -#}
104104
<div class="width-limiter"> {#- -#}
105105
<div class="sub-container"> {#- -#}
106+
{%- if page.css_class == "source" -%}
106107
<a class="sub-logo-container" href="{{page.root_path|safe}}{{krate_with_trailing_slash|safe}}index.html"> {#- -#}
107108
{%- if !layout.logo.is_empty() %}
108109
<img src="{{layout.logo}}" alt="logo"> {#- -#}
109110
{%- else -%}
110111
<img class="rust-logo" src="{{static_root_path|safe}}rust-logo{{page.resource_suffix}}.svg" alt="logo"> {#- -#}
111112
{%- endif -%}
112113
</a> {#- -#}
114+
{%- endif -%}
113115
<nav class="sub"> {#- -#}
114116
<form class="search-form"> {#- -#}
115117
<div class="search-container"> {#- -#}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
// Note: this test is paired with logo-class.rs.
22
// @has logo_class_default/struct.SomeStruct.html '//*[@class="logo-container"]/img[@class="rust-logo"]' ''
3-
// @has logo_class_default/struct.SomeStruct.html '//*[@class="sub-logo-container"]/img[@class="rust-logo"]' ''
3+
// @has src/logo_class_default/logo-class-default.rs.html '//*[@class="sub-logo-container"]/img[@class="rust-logo"]' ''
44
pub struct SomeStruct;

src/test/rustdoc/logo-class.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
// @has logo_class/struct.SomeStruct.html '//*[@class="logo-container"]/img[@src="https://raw.githubusercontent.com/sagebind/isahc/master/media/isahc.svg.png"]' ''
66
// @!has logo_class/struct.SomeStruct.html '//*[@class="logo-container"]/img[@class="rust-logo"]' ''
77
//
8-
// @has logo_class/struct.SomeStruct.html '//*[@class="sub-logo-container"]/img[@src="https://raw.githubusercontent.com/sagebind/isahc/master/media/isahc.svg.png"]' ''
9-
// @!has logo_class/struct.SomeStruct.html '//*[@class="sub-logo-container"]/img[@class="rust-logo"]' ''
8+
// @has src/logo_class/logo-class.rs.html '//*[@class="sub-logo-container"]/img[@src="https://raw.githubusercontent.com/sagebind/isahc/master/media/isahc.svg.png"]' ''
9+
// @!has src/logo_class/logo-class.rs.html '//*[@class="sub-logo-container"]/img[@class="rust-logo"]' ''
1010
pub struct SomeStruct;

0 commit comments

Comments
 (0)