Skip to content

Commit 845774e

Browse files
committed
Make job x86_64-gnu-debug run all of the run-make tests
It looks like this job was intending to run all of the `needs-matching-clang` tests (since they don't run without `RUSTBUILD_FORCE_CLANG_BASED_TESTS`), but over time developed two problems: - The tests it cares about were moved from run-make-fulldeps to run-make. - Some of the relevant tests don't actually have "clang" in their name. By running all of run-make (instead of an empty subset of run-make-fulldeps), this change should hopefully restore the previous intent of the clang-specific parts of this job.
1 parent 92a56ff commit 845774e

File tree

1 file changed

+7
-1
lines changed
  • src/ci/docker/host-x86_64/x86_64-gnu-debug

1 file changed

+7
-1
lines changed

src/ci/docker/host-x86_64/x86_64-gnu-debug/Dockerfile

+7-1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,12 @@ ENV RUST_CONFIGURE_ARGS \
4444
--set target.x86_64-unknown-linux-gnu.cc=clang \
4545
--set target.x86_64-unknown-linux-gnu.cxx=clang++
4646

47+
# This job appears to be checking two separate things:
48+
# - That we can build the compiler with `--enable-debug`
49+
# (without necessarily testing the result).
50+
# - That the tests with `//@ needs-matching-clang` pass, since they
51+
# don't run by default unless RUSTBUILD_FORCE_CLANG_BASED_TESTS is set.
52+
4753
ENV SCRIPT \
4854
python3 ../x.py --stage 2 build && \
49-
python3 ../x.py --stage 2 test tests/run-make-fulldeps --test-args clang
55+
python3 ../x.py --stage 2 test tests/run-make

0 commit comments

Comments
 (0)