Skip to content

Commit 8556910

Browse files
committed
Auto merge of #7529 - giraffate:update_node_version, r=flip1995,llogiq
Use node v12.x in CI In rust-lang/rust-clippy#7528 (comment), remark-cli version has been updated recently and it requires to use ESM module: https://github.com/remarkjs/remark/releases/tag/14.0.0. Node version in CI was v10.24.1, it seems to be old. changelog: none
2 parents 77af56d + 827f661 commit 8556910

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/remark.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ jobs:
2020

2121
- name: Setup Node.js
2222
uses: actions/[email protected]
23+
with:
24+
node-version: '12.x'
2325

2426
- name: Install remark
2527
run: npm install remark-cli remark-lint remark-lint-maximum-line-length remark-preset-lint-recommended remark-gfm

doc/basics.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,8 @@ rustup component add clippy
166166
```
167167

168168
> **DO NOT** install using `cargo install --path . --force` since this will overwrite rustup
169-
[proxies](https://rust-lang.github.io/rustup/concepts/proxies.html). That is, `~/.cargo/bin/cargo-clippy` and
170-
`~/.cargo/bin/clippy-driver` should be hard or soft links to `~/.cargo/bin/rustup`. You can repair these by running
171-
`rustup update`.
169+
> [proxies](https://rust-lang.github.io/rustup/concepts/proxies.html). That is, `~/.cargo/bin/cargo-clippy` and
170+
> `~/.cargo/bin/clippy-driver` should be hard or soft links to `~/.cargo/bin/rustup`. You can repair these by running
171+
> `rustup update`.
172172
173173
[glossary]: https://rustc-dev-guide.rust-lang.org/appendix/glossary.html

0 commit comments

Comments
 (0)