Skip to content

Commit 88fb4c4

Browse files
committed
Report lint names in json diagnostics
1 parent 2379faa commit 88fb4c4

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src/librustc/lint/mod.rs

+2
Original file line numberDiff line numberDiff line change
@@ -463,6 +463,8 @@ pub fn struct_lint_level<'a>(sess: &'a Session,
463463
}
464464
}
465465

466+
err.code(name);
467+
466468
// Check for future incompatibility lints and issue a stronger warning.
467469
let lints = sess.lint_store.borrow();
468470
if let Some(future_incompatible) = lints.future_incompatible(LintId::of(lint)) {

src/librustc_errors/emitter.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -906,7 +906,8 @@ impl EmitterWriter {
906906
} else {
907907
buffer.append(0, &level.to_string(), Style::Level(level.clone()));
908908
match code {
909-
&Some(ref code) => {
909+
// only render error codes, not lint codes
910+
&Some(ref code) if code.starts_with("E") && code.len() == 5 => {
910911
buffer.append(0, "[", Style::Level(level.clone()));
911912
buffer.append(0, &code, Style::Level(level.clone()));
912913
buffer.append(0, "]", Style::Level(level.clone()));
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"message":"unnecessary parentheses around assigned value","code":null,"level":"warning","spans":[{"file_name":"$DIR/unused_parens_json_suggestion.rs","byte_start":1001,"byte_end":1014,"line_start":24,"line_end":24,"column_start":14,"column_end":27,"is_primary":true,"text":[{"text":" let _a = (1 / (2 + 3));","highlight_start":14,"highlight_end":27}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"$DIR/unused_parens_json_suggestion.rs","byte_start":847,"byte_end":860,"line_start":19,"line_end":19,"column_start":9,"column_end":22,"is_primary":true,"text":[{"text":"#![warn(unused_parens)]","highlight_start":9,"highlight_end":22}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[],"rendered":null},{"message":"remove these parentheses","code":null,"level":"help","spans":[{"file_name":"$DIR/unused_parens_json_suggestion.rs","byte_start":1001,"byte_end":1014,"line_start":24,"line_end":24,"column_start":14,"column_end":27,"is_primary":true,"text":[{"text":" let _a = (1 / (2 + 3));","highlight_start":14,"highlight_end":27}],"label":null,"suggested_replacement":"1 / (2 + 3)","expansion":null}],"children":[],"rendered":null}],"rendered":null}
1+
{"message":"unnecessary parentheses around assigned value","code":{"code":"unused_parens","explanation":null},"level":"warning","spans":[{"file_name":"$DIR/unused_parens_json_suggestion.rs","byte_start":1001,"byte_end":1014,"line_start":24,"line_end":24,"column_start":14,"column_end":27,"is_primary":true,"text":[{"text":" let _a = (1 / (2 + 3));","highlight_start":14,"highlight_end":27}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"$DIR/unused_parens_json_suggestion.rs","byte_start":847,"byte_end":860,"line_start":19,"line_end":19,"column_start":9,"column_end":22,"is_primary":true,"text":[{"text":"#![warn(unused_parens)]","highlight_start":9,"highlight_end":22}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[],"rendered":null},{"message":"remove these parentheses","code":null,"level":"help","spans":[{"file_name":"$DIR/unused_parens_json_suggestion.rs","byte_start":1001,"byte_end":1014,"line_start":24,"line_end":24,"column_start":14,"column_end":27,"is_primary":true,"text":[{"text":" let _a = (1 / (2 + 3));","highlight_start":14,"highlight_end":27}],"label":null,"suggested_replacement":"1 / (2 + 3)","expansion":null}],"children":[],"rendered":null}],"rendered":null}

0 commit comments

Comments
 (0)