Skip to content

Commit 8925875

Browse files
committed
add FIXME for issue #1184
1 parent 0d87447 commit 8925875

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/comp/middle/trans.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ fn type_of_inner(cx: @crate_ctxt, sp: span, t: ty::t)
195195
ty::ty_res(_, sub, tps) {
196196
let sub1 = ty::substitute_type_params(cx.tcx, tps, sub);
197197
check non_ty_var(cx, sub1);
198+
// FIXME #1184: Resource flag is larger than necessary
198199
ret T_struct([cx.int_type, type_of_inner(cx, sp, sub1)]);
199200
}
200201
ty::ty_var(_) {
@@ -1474,6 +1475,7 @@ fn trans_res_drop(cx: @block_ctxt, rs: ValueRef, did: ast::def_id,
14741475
Call(cx, dtor_addr, args + [val_cast]);
14751476

14761477
cx = drop_ty(cx, val.val, inner_t_s);
1478+
// FIXME #1184: Resource flag is larger than necessary
14771479
Store(cx, C_int(ccx, 0), drop_flag.val);
14781480
Br(cx, next_cx.llbb);
14791481
ret next_cx;
@@ -1979,6 +1981,7 @@ fn call_memmove(cx: @block_ctxt, dst: ValueRef, src: ValueRef,
19791981
let memmove = i.get(key);
19801982
let src_ptr = PointerCast(cx, src, T_ptr(T_i8()));
19811983
let dst_ptr = PointerCast(cx, dst, T_ptr(T_i8()));
1984+
// FIXME #1184: Resource flag is larger than necessary
19821985
let size = IntCast(cx, n_bytes, ccx.int_type);
19831986
let align = C_i32(1i32);
19841987
let volatile = C_bool(false);
@@ -5172,6 +5175,7 @@ fn trans_res_ctor(cx: @local_ctxt, sp: span, dtor: ast::_fn,
51725175
check type_is_tup_like(bcx, tup_t);
51735176
let flag = GEP_tup_like(bcx, tup_t, llretptr, [0, 0]);
51745177
bcx = flag.bcx;
5178+
// FIXME #1184: Resource flag is larger than necessary
51755179
let one = C_int(ccx, 1);
51765180
Store(bcx, one, flag.val);
51775181
build_return(bcx);

0 commit comments

Comments
 (0)