Skip to content

Commit 99f3bfc

Browse files
committed
convert TODOs to FIXMEs
1 parent 013c37a commit 99f3bfc

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/librustc_mir/build/expr/category.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ impl Category {
8787
ExprKind::Break { .. } |
8888
ExprKind::Continue { .. } |
8989
ExprKind::Return { .. } =>
90-
Some(Category::Rvalue(RvalueFunc::Into)), // TODO
90+
// FIXME(#27840) these probably want their own
91+
// category, like "nonterminating"
92+
Some(Category::Rvalue(RvalueFunc::Into)),
9193
}
9294
}
9395
}

src/librustc_mir/tcx/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ impl<'a,'tcx:'a> Hair for Cx<'a, 'tcx> {
106106

107107
fn needs_drop(&mut self, ty: Ty<'tcx>, span: Self::Span) -> bool {
108108
if self.infcx.type_moves_by_default(ty, span) {
109-
// TODO we should do an add'l check here to determine if
109+
// FIXME(#21859) we should do an add'l check here to determine if
110110
// any dtor will execute, but the relevant fn
111111
// (`type_needs_drop`) is currently factored into
112112
// `librustc_trans`, so we can't easily do so.

0 commit comments

Comments
 (0)