Explain why the DW_TAG_* constants remain as-is for now

Author: Zalathar

compiler/rustc_codegen_llvm/src/debuginfo/mod.rs

@@ -48,6 +48,10 @@ mod utils;
 use self::create_scope_map::compute_mir_scopes;
 pub(crate) use self::metadata::build_global_var_di_node;
 
+// FIXME(Zalathar): These `DW_TAG_*` constants are fake values that were
+// removed from LLVM in 2015, and are only used by our own `RustWrapper.cpp`
+// to decide which C++ API to call. Instead, we should just have two separate
+// FFI functions and choose the correct one on the Rust side.
 #[allow(non_upper_case_globals)]
 const DW_TAG_auto_variable: c_uint = 0x100;
 #[allow(non_upper_case_globals)]

compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp

@@ -56,9 +56,7 @@ using namespace llvm::object;
 
 // This opcode is an LLVM detail that could hypothetically change, so verify
 // that the hard-coded value in `dwarf_const.rs` still agrees with LLVM.
-static_assert(
-    dwarf::DW_OP_LLVM_fragment == 0x1000,
-    "DW_OP_LLVM_fragment has changed from the value used by Rust-side code");
+static_assert(dwarf::DW_OP_LLVM_fragment == 0x1000);
 
 // LLVMAtomicOrdering is already an enum - don't create another
 // one.