Skip to content

Commit 9c47ebb

Browse files
committed
Auto merge of #25550 - sfackler:derive-debug-unsized, r=alexcrichton
Closes #25394
2 parents b301e02 + 1973ee4 commit 9c47ebb

File tree

2 files changed

+25
-5
lines changed

2 files changed

+25
-5
lines changed

src/libsyntax/ext/deriving/show.rs

+11-5
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ fn show_substructure(cx: &mut ExtCtxt, span: Span,
7575

7676
match *substr.fields {
7777
Struct(ref fields) | EnumMatching(_, _, ref fields) => {
78+
7879
if fields.is_empty() || fields[0].name.is_none() {
7980
// tuple struct/"normal" variant
8081
expr = cx.expr_method_call(span,
@@ -83,11 +84,14 @@ fn show_substructure(cx: &mut ExtCtxt, span: Span,
8384
vec![name]);
8485

8586
for field in fields {
87+
// Use double indirection to make sure this works for unsized types
88+
let field = cx.expr_addr_of(field.span, field.self_.clone());
89+
let field = cx.expr_addr_of(field.span, field);
90+
8691
expr = cx.expr_method_call(span,
8792
expr,
8893
token::str_to_ident("field"),
89-
vec![cx.expr_addr_of(field.span,
90-
field.self_.clone())]);
94+
vec![field]);
9195
}
9296
} else {
9397
// normal struct/struct variant
@@ -100,12 +104,14 @@ fn show_substructure(cx: &mut ExtCtxt, span: Span,
100104
let name = cx.expr_lit(field.span, ast::Lit_::LitStr(
101105
token::get_ident(field.name.clone().unwrap()),
102106
ast::StrStyle::CookedStr));
107+
108+
// Use double indirection to make sure this works for unsized types
109+
let field = cx.expr_addr_of(field.span, field.self_.clone());
110+
let field = cx.expr_addr_of(field.span, field);
103111
expr = cx.expr_method_call(span,
104112
expr,
105113
token::str_to_ident("field"),
106-
vec![name,
107-
cx.expr_addr_of(field.span,
108-
field.self_.clone())]);
114+
vec![name, field]);
109115
}
110116
}
111117
}

src/test/run-pass/issue-25394.rs

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
#[derive(Debug)]
12+
struct Row<T>([T]);
13+
14+
fn main() {}

0 commit comments

Comments
 (0)