Skip to content

Commit a197141

Browse files
Update ui tests
1 parent 40cff2d commit a197141

File tree

3 files changed

+14
-12
lines changed

3 files changed

+14
-12
lines changed

tests/ui/iter_filter_is_some.fixed

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
clippy::result_filter_map,
55
clippy::needless_borrow,
66
clippy::option_filter_map,
7-
clippy::redundant_closure
7+
clippy::redundant_closure,
8+
clippy::unnecessary_get_then_check
89
)]
910

1011
use std::collections::HashMap;

tests/ui/iter_filter_is_some.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
clippy::result_filter_map,
55
clippy::needless_borrow,
66
clippy::option_filter_map,
7-
clippy::redundant_closure
7+
clippy::redundant_closure,
8+
clippy::unnecessary_get_then_check
89
)]
910

1011
use std::collections::HashMap;

tests/ui/iter_filter_is_some.stderr

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
error: `filter` for `is_some` on iterator over `Option`
2-
--> tests/ui/iter_filter_is_some.rs:14:58
2+
--> tests/ui/iter_filter_is_some.rs:15:58
33
|
44
LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(Option::is_some);
55
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
@@ -8,55 +8,55 @@ LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(Option::is_
88
= help: to override `-D warnings` add `#[allow(clippy::iter_filter_is_some)]`
99

1010
error: `filter` for `is_some` on iterator over `Option`
11-
--> tests/ui/iter_filter_is_some.rs:16:58
11+
--> tests/ui/iter_filter_is_some.rs:17:58
1212
|
1313
LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(|a| a.is_some());
1414
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
1515

1616
error: `filter` for `is_some` on iterator over `Option`
17-
--> tests/ui/iter_filter_is_some.rs:19:58
17+
--> tests/ui/iter_filter_is_some.rs:20:58
1818
|
1919
LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(|o| { o.is_some() });
2020
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
2121

2222
error: `filter` for `is_some` on iterator over `Option`
23-
--> tests/ui/iter_filter_is_some.rs:26:14
23+
--> tests/ui/iter_filter_is_some.rs:27:14
2424
|
2525
LL | .filter(std::option::Option::is_some);
2626
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
2727

2828
error: `filter` for `is_some` on iterator over `Option`
29-
--> tests/ui/iter_filter_is_some.rs:31:14
29+
--> tests/ui/iter_filter_is_some.rs:32:14
3030
|
3131
LL | .filter(|a| std::option::Option::is_some(a));
3232
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
3333

3434
error: `filter` for `is_some` on iterator over `Option`
35-
--> tests/ui/iter_filter_is_some.rs:34:58
35+
--> tests/ui/iter_filter_is_some.rs:35:58
3636
|
3737
LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(|a| { std::option::Option::is_some(a) });
3838
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
3939

4040
error: `filter` for `is_some` on iterator over `Option`
41-
--> tests/ui/iter_filter_is_some.rs:39:58
41+
--> tests/ui/iter_filter_is_some.rs:40:58
4242
|
4343
LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(|&a| a.is_some());
4444
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
4545

4646
error: `filter` for `is_some` on iterator over `Option`
47-
--> tests/ui/iter_filter_is_some.rs:43:58
47+
--> tests/ui/iter_filter_is_some.rs:44:58
4848
|
4949
LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(|&o| { o.is_some() });
5050
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
5151

5252
error: `filter` for `is_some` on iterator over `Option`
53-
--> tests/ui/iter_filter_is_some.rs:48:58
53+
--> tests/ui/iter_filter_is_some.rs:49:58
5454
|
5555
LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(|ref a| a.is_some());
5656
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`
5757

5858
error: `filter` for `is_some` on iterator over `Option`
59-
--> tests/ui/iter_filter_is_some.rs:52:58
59+
--> tests/ui/iter_filter_is_some.rs:53:58
6060
|
6161
LL | let _ = vec![Some(1), None, Some(3)].into_iter().filter(|ref o| { o.is_some() });
6262
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()`

0 commit comments

Comments
 (0)