Skip to content

Commit ac229c2

Browse files
committed
fix clippy::iter_kv_map
1 parent 0196c2b commit ac229c2

File tree

7 files changed

+10
-15
lines changed

7 files changed

+10
-15
lines changed

compiler/rustc_hir_analysis/src/astconv/errors.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -483,8 +483,8 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
483483
[segment] if segment.args.is_none() => {
484484
trait_bound_spans = vec![segment.ident.span];
485485
associated_types = associated_types
486-
.into_iter()
487-
.map(|(_, items)| (segment.ident.span, items))
486+
.into_values()
487+
.map(|items| (segment.ident.span, items))
488488
.collect();
489489
}
490490
_ => {}

compiler/rustc_infer/src/infer/error_reporting/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -978,7 +978,7 @@ impl<'tcx> TypeErrCtxt<'_, 'tcx> {
978978
let (_, sig, reg) = ty::print::FmtPrinter::new(self.tcx, Namespace::TypeNS)
979979
.name_all_regions(sig)
980980
.unwrap();
981-
let lts: Vec<String> = reg.into_iter().map(|(_, kind)| kind.to_string()).collect();
981+
let lts: Vec<String> = reg.into_values().map(|kind| kind.to_string()).collect();
982982
(if lts.is_empty() { String::new() } else { format!("for<{}> ", lts.join(", ")) }, sig)
983983
};
984984

compiler/rustc_middle/src/middle/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ pub mod lib_features {
1919
.stable
2020
.iter()
2121
.map(|(f, (s, _))| (*f, Some(*s)))
22-
.chain(self.unstable.iter().map(|(f, _)| (*f, None)))
22+
.chain(self.unstable.keys().map(|f| (*f, None)))
2323
.collect();
2424
all_features.sort_unstable_by(|a, b| a.0.as_str().partial_cmp(b.0.as_str()).unwrap());
2525
all_features

compiler/rustc_monomorphize/src/partitioning/default.rs

+1-4
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,7 @@ impl<'tcx> Partitioner<'tcx> for DefaultPartitioning {
8989
}
9090

9191
PreInliningPartitioning {
92-
codegen_units: codegen_units
93-
.into_iter()
94-
.map(|(_, codegen_unit)| codegen_unit)
95-
.collect(),
92+
codegen_units: codegen_units.into_values().map(|codegen_unit| codegen_unit).collect(),
9693
roots,
9794
internalization_candidates,
9895
}

compiler/rustc_resolve/src/diagnostics.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1669,8 +1669,8 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> {
16691669
) -> Option<Symbol> {
16701670
let mut candidates = self
16711671
.extern_prelude
1672-
.iter()
1673-
.map(|(ident, _)| ident.name)
1672+
.keys()
1673+
.map(|ident| ident.name)
16741674
.chain(
16751675
self.module_map
16761676
.iter()
@@ -2007,7 +2007,7 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> {
20072007
// 1) some consistent ordering for emitted diagnostics, and
20082008
// 2) `std` suggestions before `core` suggestions.
20092009
let mut extern_crate_names =
2010-
self.extern_prelude.iter().map(|(ident, _)| ident.name).collect::<Vec<_>>();
2010+
self.extern_prelude.keys().map(|ident| ident.name).collect::<Vec<_>>();
20112011
extern_crate_names.sort_by(|a, b| b.as_str().partial_cmp(a.as_str()).unwrap());
20122012

20132013
for name in extern_crate_names.into_iter() {

compiler/rustc_resolve/src/late.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -2421,8 +2421,7 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
24212421
.iter()
24222422
.rfind(|r| matches!(r.kind, ItemRibKind(_)))
24232423
.expect("associated item outside of an item");
2424-
seen_bindings
2425-
.extend(parent_rib.bindings.iter().map(|(ident, _)| (*ident, ident.span)));
2424+
seen_bindings.extend(parent_rib.bindings.keys().map(|ident| (*ident, ident.span)));
24262425
};
24272426
add_bindings_for_ns(ValueNS);
24282427
add_bindings_for_ns(TypeNS);

compiler/rustc_traits/src/chalk/lowering.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -909,8 +909,7 @@ pub(crate) fn collect_bound_vars<'tcx, T: TypeFoldable<TyCtxt<'tcx>>>(
909909
.or_else(|| bug!("Skipped bound var index: parameters={:?}", parameters));
910910
});
911911

912-
let binders =
913-
chalk_ir::VariableKinds::from_iter(interner, parameters.into_iter().map(|(_, v)| v));
912+
let binders = chalk_ir::VariableKinds::from_iter(interner, parameters.into_values());
914913

915914
(new_ty, binders, named_parameters)
916915
}

0 commit comments

Comments
 (0)