Write the format string parserand split it from conditions parser

Author: mejrs

compiler/rustc_span/src/symbol.rs

@@ -372,6 +372,7 @@ symbols! {
         SyncUnsafeCell,
         T,
         Target,
+        This,
         ToOwned,
         ToString,
         TokenStream,
@@ -2082,6 +2083,7 @@ symbols! {
         test_removed_feature,
         test_runner,
         test_unstable_lint,
+
         thread,
         thread_local,
         thread_local_macro,

compiler/rustc_trait_selection/src/error_reporting/traits/mod.rs

@@ -2,6 +2,7 @@ pub mod ambiguity;
 pub mod call_kind;
 mod fulfillment_errors;
 pub mod on_unimplemented;
+pub mod on_unimplemented_condition;
 pub mod on_unimplemented_format;
 mod overflow;
 pub mod suggestions;

compiler/rustc_trait_selection/src/error_reporting/traits/on_unimplemented.rs

@@ -0,0 +1,64 @@
+use rustc_ast::MetaItemInner;
+use rustc_attr_parsing as attr;
+use rustc_data_structures::fx::FxHashMap;
+use rustc_middle::ty::{self, TyCtxt};
+use rustc_parse_format::{ParseMode, Parser, Piece, Position};
+use rustc_span::{Span, Symbol, sym};
+
+pub static ALLOWED_CONDITION_SYMBOLS: &[Symbol] = &[
+    sym::from_desugaring,
+    sym::direct,
+    sym::cause,
+    sym::integral,
+    sym::integer_,
+    sym::float,
+    sym::_Self,
+    sym::crate_local,
+];
+
+#[derive(Debug)]
+pub struct Condition {
+    pub inner: MetaItemInner,
+}
+
+impl Condition {
+    pub fn span(&self) -> Span {
+        self.inner.span()
+    }
+
+    pub fn matches_predicate<'tcx>(
+        &self,
+        tcx: TyCtxt<'tcx>,
+        options: &[(Symbol, Option<String>)],
+        options_map: &FxHashMap<Symbol, String>,
+    ) -> bool {
+        attr::eval_condition(&self.inner, tcx.sess, Some(tcx.features()), &mut |cfg| {
+            let value = cfg.value.map(|v| {
+                // `with_no_visible_paths` is also used when generating the options,
+                // so we need to match it here.
+                ty::print::with_no_visible_paths!({
+                    let mut parser = Parser::new(v.as_str(), None, None, false, ParseMode::Format);
+                    let constructed_message = (&mut parser)
+                        .map(|p| match p {
+                            Piece::Lit(s) => s.to_owned(),
+                            Piece::NextArgument(a) => match a.position {
+                                Position::ArgumentNamed(arg) => {
+                                    let s = Symbol::intern(arg);
+                                    match options_map.get(&s) {
+                                        Some(val) => val.to_string(),
+                                        None => format!("{{{arg}}}"),
+                                    }
+                                }
+                                Position::ArgumentImplicitlyIs(_) => String::from("{}"),
+                                Position::ArgumentIs(idx) => format!("{{{idx}}}"),
+                            },
+                        })
+                        .collect();
+                    constructed_message
+                })
+            });
+
+            options.contains(&(cfg.name, value))
+        })
+    }
+}