Skip to content

Commit cdedd26

Browse files
Make use of existing constants.
f32::consts::PI / 2.0 -> f32::consts::FRAC_PI_2 f32::consts::PI / 4.0 -> f32::consts::FRAC_PI_4 f64::consts::PI / 2.0 -> f64::consts::FRAC_PI_2 f64::consts::PI / 4.0 -> f64::consts::FRAC_PI_4
1 parent 3b04e91 commit cdedd26

File tree

2 files changed

+18
-20
lines changed

2 files changed

+18
-20
lines changed

src/libstd/f32.rs

+9-10
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ impl f32 {
600600
/// ```
601601
/// use std::f32;
602602
///
603-
/// let x = f32::consts::PI/2.0;
603+
/// let x = f32::consts::FRAC_PI_2;
604604
///
605605
/// let abs_difference = (x.sin() - 1.0).abs();
606606
///
@@ -646,7 +646,7 @@ impl f32 {
646646
/// ```
647647
/// use std::f32;
648648
///
649-
/// let x = f32::consts::PI / 4.0;
649+
/// let x = f32::consts::FRAC_PI_4;
650650
/// let abs_difference = (x.tan() - 1.0).abs();
651651
///
652652
/// assert!(abs_difference <= f32::EPSILON);
@@ -666,10 +666,10 @@ impl f32 {
666666
/// ```
667667
/// use std::f32;
668668
///
669-
/// let f = f32::consts::PI / 2.0;
669+
/// let f = f32::consts::FRAC_PI_2;
670670
///
671671
/// // asin(sin(pi/2))
672-
/// let abs_difference = (f.sin().asin() - f32::consts::PI / 2.0).abs();
672+
/// let abs_difference = (f.sin().asin() - f32::consts::FRAC_PI_2).abs();
673673
///
674674
/// assert!(abs_difference <= f32::EPSILON);
675675
/// ```
@@ -688,10 +688,10 @@ impl f32 {
688688
/// ```
689689
/// use std::f32;
690690
///
691-
/// let f = f32::consts::PI / 4.0;
691+
/// let f = f32::consts::FRAC_PI_4;
692692
///
693693
/// // acos(cos(pi/4))
694-
/// let abs_difference = (f.cos().acos() - f32::consts::PI / 4.0).abs();
694+
/// let abs_difference = (f.cos().acos() - f32::consts::FRAC_PI_4).abs();
695695
///
696696
/// assert!(abs_difference <= f32::EPSILON);
697697
/// ```
@@ -734,7 +734,6 @@ impl f32 {
734734
/// ```
735735
/// use std::f32;
736736
///
737-
/// let pi = f32::consts::PI;
738737
/// // Positive angles measured counter-clockwise
739738
/// // from positive x axis
740739
/// // -pi/4 radians (45 deg clockwise)
@@ -745,8 +744,8 @@ impl f32 {
745744
/// let x2 = -3.0f32;
746745
/// let y2 = 3.0f32;
747746
///
748-
/// let abs_difference_1 = (y1.atan2(x1) - (-pi / 4.0)).abs();
749-
/// let abs_difference_2 = (y2.atan2(x2) - (3.0 * pi / 4.0)).abs();
747+
/// let abs_difference_1 = (y1.atan2(x1) - (-f32::consts::FRAC_PI_4)).abs();
748+
/// let abs_difference_2 = (y2.atan2(x2) - (3.0 * f32::consts::FRAC_PI_4)).abs();
750749
///
751750
/// assert!(abs_difference_1 <= f32::EPSILON);
752751
/// assert!(abs_difference_2 <= f32::EPSILON);
@@ -765,7 +764,7 @@ impl f32 {
765764
/// ```
766765
/// use std::f32;
767766
///
768-
/// let x = f32::consts::PI/4.0;
767+
/// let x = f32::consts::FRAC_PI_4;
769768
/// let f = x.sin_cos();
770769
///
771770
/// let abs_difference_0 = (f.0 - x.sin()).abs();

src/libstd/f64.rs

+9-10
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ impl f64 {
537537
/// ```
538538
/// use std::f64;
539539
///
540-
/// let x = f64::consts::PI/2.0;
540+
/// let x = f64::consts::FRAC_PI_2;
541541
///
542542
/// let abs_difference = (x.sin() - 1.0).abs();
543543
///
@@ -575,7 +575,7 @@ impl f64 {
575575
/// ```
576576
/// use std::f64;
577577
///
578-
/// let x = f64::consts::PI/4.0;
578+
/// let x = f64::consts::FRAC_PI_4;
579579
/// let abs_difference = (x.tan() - 1.0).abs();
580580
///
581581
/// assert!(abs_difference < 1e-14);
@@ -595,10 +595,10 @@ impl f64 {
595595
/// ```
596596
/// use std::f64;
597597
///
598-
/// let f = f64::consts::PI / 2.0;
598+
/// let f = f64::consts::FRAC_PI_2;
599599
///
600600
/// // asin(sin(pi/2))
601-
/// let abs_difference = (f.sin().asin() - f64::consts::PI / 2.0).abs();
601+
/// let abs_difference = (f.sin().asin() - f64::consts::FRAC_PI_2).abs();
602602
///
603603
/// assert!(abs_difference < 1e-10);
604604
/// ```
@@ -617,10 +617,10 @@ impl f64 {
617617
/// ```
618618
/// use std::f64;
619619
///
620-
/// let f = f64::consts::PI / 4.0;
620+
/// let f = f64::consts::FRAC_PI_4;
621621
///
622622
/// // acos(cos(pi/4))
623-
/// let abs_difference = (f.cos().acos() - f64::consts::PI / 4.0).abs();
623+
/// let abs_difference = (f.cos().acos() - f64::consts::FRAC_PI_4).abs();
624624
///
625625
/// assert!(abs_difference < 1e-10);
626626
/// ```
@@ -661,7 +661,6 @@ impl f64 {
661661
/// ```
662662
/// use std::f64;
663663
///
664-
/// let pi = f64::consts::PI;
665664
/// // Positive angles measured counter-clockwise
666665
/// // from positive x axis
667666
/// // -pi/4 radians (45 deg clockwise)
@@ -672,8 +671,8 @@ impl f64 {
672671
/// let x2 = -3.0_f64;
673672
/// let y2 = 3.0_f64;
674673
///
675-
/// let abs_difference_1 = (y1.atan2(x1) - (-pi / 4.0)).abs();
676-
/// let abs_difference_2 = (y2.atan2(x2) - (3.0 * pi / 4.0)).abs();
674+
/// let abs_difference_1 = (y1.atan2(x1) - (-f64::consts::FRAC_PI_4)).abs();
675+
/// let abs_difference_2 = (y2.atan2(x2) - (3.0 * f64::consts::FRAC_PI_4)).abs();
677676
///
678677
/// assert!(abs_difference_1 < 1e-10);
679678
/// assert!(abs_difference_2 < 1e-10);
@@ -692,7 +691,7 @@ impl f64 {
692691
/// ```
693692
/// use std::f64;
694693
///
695-
/// let x = f64::consts::PI/4.0;
694+
/// let x = f64::consts::FRAC_PI_4;
696695
/// let f = x.sin_cos();
697696
///
698697
/// let abs_difference_0 = (f.0 - x.sin()).abs();

0 commit comments

Comments
 (0)