Skip to content

Commit d9c6761

Browse files
committed
prefer compile::stream_cargo for building tools
Previously, we were running bare commands for `ToolBuild` step and were unable to utilize some of the flags which are already handled by `compile::stream_cargo`. This change makes `ToolBuild` to use `compile::stream_cargo`, allowing us to benefit from the flags supported by the bootstrap cargo. Signed-off-by: onur-ozkan <[email protected]>
1 parent 7516912 commit d9c6761

File tree

1 file changed

+1
-3
lines changed
  • src/bootstrap/src/core/build_steps

1 file changed

+1
-3
lines changed

src/bootstrap/src/core/build_steps/tool.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ use crate::core::builder;
99
use crate::core::builder::{Builder, Cargo as CargoCommand, RunConfig, ShouldRun, Step};
1010
use crate::core::config::TargetSelection;
1111
use crate::utils::channel::GitInfo;
12-
use crate::utils::exec::BootstrapCommand;
1312
use crate::utils::helpers::{add_dylib_path, exe, t};
1413
use crate::Compiler;
1514
use crate::Mode;
@@ -109,9 +108,8 @@ impl Step for ToolBuild {
109108
&self.target,
110109
);
111110

112-
let mut cargo = Command::from(cargo);
113111
// we check this below
114-
let build_success = builder.run_cmd(BootstrapCommand::from(&mut cargo).allow_failure());
112+
let build_success = compile::stream_cargo(builder, cargo, vec![], &mut |_| {});
115113

116114
builder.save_toolstate(
117115
tool,

0 commit comments

Comments
 (0)