Remove ignore-uefi from tests

Do not ignore any tests for UEFI unless they do not fail gracefully.
This should help reduce the surface area of this PR by a lot. Maybe
think about ignoring them once this PR is merged.

Signed-off-by: Ayush Singh <[email protected]>

Author: Ayush1325

library/std/src/sys/uefi/stdio.rs

@@ -159,12 +159,6 @@ impl Stderr {
 
 impl io::Write for Stderr {
     fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
-        // Since wrtiting to stderr might be tried due to a panic caused by unintialized GLOBALS,
-        // this check ensures we do not cause an inifinte panic loop.
-        if !uefi::env::GLOBALS.is_completed() {
-            return Err(io::const_io_error!(io::ErrorKind::Other, "Globals not intialized"));
-        }
-
         if let Some(command_protocol) = common::get_current_handle_protocol::<
             uefi_command_protocol::Protocol,
         >(uefi_command_protocol::PROTOCOL_GUID)
@@ -193,7 +187,7 @@ pub fn is_ebadf(err: &io::Error) -> bool {
 
 #[inline]
 pub fn panic_output() -> Option<impl io::Write> {
-    Some(Stderr::new())
+    if uefi::env::GLOBALS.is_completed() { Some(Stderr::new()) } else { None }
 }
 
 fn utf8_to_ucs2(buf: &[u8], output: &mut [u16]) -> io::Result<usize> {

src/test/ui/abi/abi-sysv64-arg-passing.rs

@@ -28,7 +28,6 @@
 // ignore-arm
 // ignore-aarch64
 // ignore-windows
-// ignore-uefi rust_test_helpers do not work
 
 // note: windows is ignored as rust_test_helpers does not have the sysv64 abi on windows
 

src/test/ui/abi/anon-extern-mod.rs

@@ -1,7 +1,6 @@
 // run-pass
 // pretty-expanded FIXME #23616
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 #![feature(rustc_private)]
 

src/test/ui/abi/c-stack-as-value.rs

@@ -1,7 +1,6 @@
 // run-pass
 // pretty-expanded FIXME #23616
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 #![feature(rustc_private)]
 

src/test/ui/abi/c-stack-returning-int64.rs

@@ -1,7 +1,6 @@
 // run-pass
 // ignore-wasm32-bare no libc to test with
 // ignore-sgx no libc
-// ignore-uefi no libc
 
 #![feature(rustc_private)]
 

src/test/ui/abi/cabi-int-widening.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 #[link(name = "rust_test_helpers", kind = "static")]
 extern "C" {

src/test/ui/abi/cross-crate/anon-extern-mod-cross-crate-2.rs

@@ -2,7 +2,6 @@
 // aux-build:anon-extern-mod-cross-crate-1.rs
 // pretty-expanded FIXME #23616
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 extern crate anonexternmod;
 

src/test/ui/abi/cross-crate/duplicated-external-mods.rs

@@ -3,7 +3,6 @@
 // aux-build:anon-extern-mod-cross-crate-1.rs
 // pretty-expanded FIXME #23616
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 extern crate anonexternmod;
 

src/test/ui/abi/extern/extern-call-deep.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 // ignore-emscripten blows the JS stack
 
 #![feature(rustc_private)]

src/test/ui/abi/extern/extern-call-deep2.rs

@@ -1,7 +1,6 @@
 // run-pass
 #![allow(unused_must_use)]
 // ignore-emscripten no threads support
-// ignore-uefi no threads support
 #![feature(rustc_private)]
 
 extern crate libc;

src/test/ui/abi/extern/extern-call-indirect.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 #![feature(rustc_private)]
 

src/test/ui/abi/extern/extern-call-scrub.rs

@@ -5,7 +5,6 @@
 // directions
 
 // ignore-emscripten no threads support
-// ignore-uefi no threads support
 #![feature(rustc_private)]
 
 extern crate libc;

src/test/ui/abi/extern/extern-crosscrate.rs

@@ -1,7 +1,6 @@
 // run-pass
 // aux-build:extern-crosscrate-source.rs
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 #![feature(rustc_private)]
 

src/test/ui/abi/extern/extern-pass-TwoU16s.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc for ffi testing
-// ignore-uefi no rust_test_helpers
 
 // Test a foreign function that accepts and returns a struct
 // by value.

src/test/ui/abi/extern/extern-pass-TwoU32s.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc for ffi testing
-// ignore-uefi no rust_test_helpers
 
 // Test a foreign function that accepts and returns a struct
 // by value.

src/test/ui/abi/extern/extern-pass-TwoU64s.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc for ffi testing
-// ignore-uefi no rust_test_helpers
 
 // Test a foreign function that accepts and returns a struct
 // by value.

src/test/ui/abi/extern/extern-pass-TwoU8s.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc for ffi testing
-// ignore-uefi no rust_test_helpers
 
 // Test a foreign function that accepts and returns a struct
 // by value.

src/test/ui/abi/extern/extern-pass-char.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc for ffi testing
-// ignore-uefi no rust_test_helpers
 
 // Test a function that takes/returns a u8.
 

src/test/ui/abi/extern/extern-pass-double.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc for ffi testing
-// ignore-uefi no rust_test_helpers
 
 #[link(name = "rust_test_helpers", kind = "static")]
 extern "C" {

src/test/ui/abi/extern/extern-pass-empty.rs

@@ -6,7 +6,6 @@
 // pretty-expanded FIXME #23616
 // ignore-msvc
 // ignore-emscripten emcc asserts on an empty struct as an argument
-// ignore-uefi no rust_test_helpers
 
 #[repr(C)]
 struct TwoU8s {

src/test/ui/abi/extern/extern-pass-u32.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc for ffi testing
-// ignore-uefi no rust_test_helpers
 
 // Test a function that takes/returns a u32.
 

src/test/ui/abi/extern/extern-pass-u64.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc for ffi testing
-// ignore-uefi no rust_test_helpers
 
 // Test a call to a function that takes/returns a u64.
 

src/test/ui/abi/extern/extern-return-TwoU16s.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 pub struct TwoU16s {
     one: u16,

src/test/ui/abi/extern/extern-return-TwoU32s.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 pub struct TwoU32s {
     one: u32,

src/test/ui/abi/extern/extern-return-TwoU64s.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 pub struct TwoU64s {
     one: u64,

src/test/ui/abi/extern/extern-return-TwoU8s.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 pub struct TwoU8s {
     one: u8,

src/test/ui/abi/foreign/foreign-call-no-runtime.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-emscripten no threads support
-// ignore-uefi no threads support
 
 #![feature(rustc_private)]
 

src/test/ui/abi/foreign/foreign-dupe.rs

@@ -1,7 +1,6 @@
 // run-pass
 // aux-build:foreign_lib.rs
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 // Check that we can still call duplicated extern (imported) functions
 // which were declared in another crate. See issues #32740 and #32783.

src/test/ui/abi/foreign/foreign-fn-with-byval.rs

@@ -2,7 +2,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 #[derive(Copy, Clone)]
 pub struct S {

src/test/ui/abi/foreign/foreign-no-abi.rs

@@ -2,7 +2,6 @@
 // ABI is cdecl by default
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 // pretty-expanded FIXME #23616
 
 #![feature(rustc_private)]

src/test/ui/abi/foreign/invoke-external-foreign.rs

@@ -1,7 +1,6 @@
 // run-pass
 // aux-build:foreign_lib.rs
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 // The purpose of this test is to check that we can
 // successfully (and safely) invoke external, cdecl

src/test/ui/abi/issue-28676.rs

@@ -3,7 +3,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 #[derive(Copy, Clone)]
 pub struct Quad {

src/test/ui/abi/issues/issue-62350-sysv-neg-reg-counts.rs

@@ -3,7 +3,6 @@
 #![allow(improper_ctypes)]
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 #[derive(Copy, Clone)]
 pub struct QuadFloats {

src/test/ui/abi/lib-defaults.rs

@@ -2,7 +2,6 @@
 // dont-check-compiler-stderr (rust-lang/rust#54222)
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 // compile-flags: -lrust_test_helpers
 

src/test/ui/abi/mir/mir_codegen_calls_variadic.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 #[link(name = "rust_test_helpers", kind = "static")]
 extern "C" {

src/test/ui/abi/numbers-arithmetic/i128-ffi.rs

@@ -7,7 +7,6 @@
 
 // ignore-windows
 // ignore-32bit
-// ignore-uefi no rust_test_helpers
 
 #[link(name = "rust_test_helpers", kind = "static")]
 extern "C" {

src/test/ui/abi/segfault-no-out-of-stack.rs

@@ -4,7 +4,6 @@
 // ignore-emscripten can't run commands
 // ignore-sgx no processes
 // ignore-fuchsia must translate zircon signal to SIGSEGV/SIGBUS, FIXME (#58590)
-// ignore-uefi no libc
 #![feature(rustc_private)]
 
 extern crate libc;

src/test/ui/abi/stack-probes-lto.rs

@@ -9,7 +9,6 @@
 // ignore-emscripten no processes
 // ignore-sgx no processes
 // ignore-musl FIXME #31506
-// ignore-uefi no rust_test_helpers
 // ignore-pretty
 // ignore-fuchsia no exception handler registered for segfault
 // compile-flags: -C lto

src/test/ui/abi/stack-probes.rs

@@ -9,7 +9,6 @@
 // ignore-emscripten no processes
 // ignore-sgx no processes
 // ignore-fuchsia no exception handler registered for segfault
-// ignore-uefi no rust_test_helpers
 
 use std::env;
 use std::mem::MaybeUninit;

src/test/ui/abi/statics/static-mut-foreign.rs

@@ -4,7 +4,6 @@
 // attempted.
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no libc to test ffi with
 
 #![feature(rustc_private)]
 

src/test/ui/abi/struct-enums/struct-return.rs

@@ -1,7 +1,6 @@
 // run-pass
 #![allow(dead_code)]
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 #[repr(C)]
 #[derive(Copy, Clone)]

src/test/ui/abi/union/union-c-interop.rs

@@ -2,7 +2,6 @@
 #![allow(non_snake_case)]
 
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 
 #[derive(Clone, Copy)]
 #[repr(C)]

src/test/ui/abi/variadic-ffi.rs

@@ -1,6 +1,5 @@
 // run-pass
 // ignore-wasm32-bare no libc to test ffi with
-// ignore-uefi no rust_test_helpers
 #![feature(c_variadic)]
 
 use std::ffi::VaList;

src/test/ui/array-slice-vec/box-of-array-of-drop-1.rs

@@ -6,7 +6,6 @@
 // destructor.
 
 // ignore-emscripten no threads support
-// ignore-uefi no threads support
 
 use std::thread;
 use std::sync::atomic::{AtomicUsize, Ordering};

src/test/ui/array-slice-vec/box-of-array-of-drop-2.rs

@@ -6,7 +6,6 @@
 // destructor.
 
 // ignore-emscripten no threads support
-// ignore-uefi no threads support
 
 use std::thread;
 use std::sync::atomic::{AtomicUsize, Ordering};

src/test/ui/array-slice-vec/nested-vec-3.rs

@@ -3,7 +3,6 @@
 #![allow(overflowing_literals)]
 
 // ignore-emscripten no threads support
-// ignore-uefi no threads support
 
 // Test that using the `vec!` macro nested within itself works when
 // the contents implement Drop and we hit a panic in the middle of

src/test/ui/array-slice-vec/slice-panic-1.rs

@@ -2,7 +2,6 @@
 // needs-unwind
 
 // ignore-emscripten no threads support
-// ignore-uefi no threads support
 
 // Test that if a slicing expr[..] fails, the correct cleanups happen.
 

src/test/ui/array-slice-vec/slice-panic-2.rs

@@ -2,7 +2,6 @@
 // needs-unwind
 
 // ignore-emscripten no threads support
-// ignore-uefi no threads support
 
 // Test that if a slicing expr[..] fails, the correct cleanups happen.
 

src/test/ui/asm/may_unwind.rs

@@ -1,6 +1,5 @@
 // run-pass
 // needs-asm-support
-// ignore-uefi no unwind
 
 #![feature(asm_unwind)]