Remove pub(crate) in crate roots

Author: petrochenkov

src/librustc_borrowck/lib.rs

@@ -42,7 +42,7 @@ pub use borrowck::build_borrowck_dataflow_data_for_fn;
 
 // NB: This module needs to be declared first so diagnostics are
 // registered before they are used.
-pub(crate) mod diagnostics;
+mod diagnostics;
 
 mod borrowck;
 

src/librustc_const_eval/lib.rs

@@ -41,7 +41,7 @@ extern crate syntax_pos;
 
 // NB: This module needs to be declared first so diagnostics are
 // registered before they are used.
-pub(crate) mod diagnostics;
+mod diagnostics;
 
 mod eval;
 mod _match;

src/librustc_driver/lib.rs

@@ -102,10 +102,10 @@ use syntax::parse::{self, PResult};
 use syntax_pos::{DUMMY_SP, MultiSpan};
 
 #[cfg(test)]
-pub(crate) mod test;
+mod test;
 
 pub mod driver;
-pub(crate) mod pretty;
+mod pretty;
 pub mod target_features;
 mod derive_registrar;
 
@@ -273,7 +273,7 @@ pub enum Compilation {
 }
 
 impl Compilation {
-    pub(crate) fn and_then<F: FnOnce() -> Compilation>(self, next: F) -> Compilation {
+    fn and_then<F: FnOnce() -> Compilation>(self, next: F) -> Compilation {
         match self {
             Compilation::Stop => Compilation::Stop,
             Compilation::Continue => next(),
@@ -617,7 +617,7 @@ fn save_analysis_format(sess: &Session) -> save::Format {
 }
 
 impl RustcDefaultCalls {
-    pub(crate) fn list_metadata(sess: &Session, matches: &getopts::Matches, input: &Input) -> Compilation {
+    fn list_metadata(sess: &Session, matches: &getopts::Matches, input: &Input) -> Compilation {
         let r = matches.opt_strs("Z");
         if r.contains(&("ls".to_string())) {
             match input {
@@ -759,17 +759,17 @@ impl RustcDefaultCalls {
 }
 
 /// Returns a version string such as "0.12.0-dev".
-pub(crate) fn release_str() -> Option<&'static str> {
+fn release_str() -> Option<&'static str> {
     option_env!("CFG_RELEASE")
 }
 
 /// Returns the full SHA1 hash of HEAD of the Git repo from which rustc was built.
-pub(crate) fn commit_hash_str() -> Option<&'static str> {
+fn commit_hash_str() -> Option<&'static str> {
     option_env!("CFG_VER_HASH")
 }
 
 /// Returns the "commit date" of HEAD of the Git repo from which rustc was built as a static string.
-pub(crate) fn commit_date_str() -> Option<&'static str> {
+fn commit_date_str() -> Option<&'static str> {
     option_env!("CFG_VER_DATE")
 }
 
@@ -1016,7 +1016,7 @@ fn print_flag_list<T>(cmdline_opt: &str,
 ///
 /// So with all that in mind, the comments below have some more detail about the
 /// contortions done here to get things to work out correctly.
-pub(crate) fn handle_options(args: &[String]) -> Option<getopts::Matches> {
+fn handle_options(args: &[String]) -> Option<getopts::Matches> {
     // Throw away the first argument, the name of the binary
     let args = &args[1..];
 
@@ -1200,7 +1200,7 @@ fn exit_on_err() -> ! {
     panic!();
 }
 
-pub(crate) fn diagnostics_registry() -> errors::registry::Registry {
+fn diagnostics_registry() -> errors::registry::Registry {
     use errors::registry::Registry;
 
     let mut all_errors = Vec::new();

src/librustc_errors/lib.rs

@@ -38,8 +38,8 @@ use std::cell::{RefCell, Cell};
 use std::{error, fmt};
 use std::rc::Rc;
 
-pub(crate) mod diagnostic;
-pub(crate) mod diagnostic_builder;
+mod diagnostic;
+mod diagnostic_builder;
 pub mod emitter;
 mod snippet;
 pub mod registry;
@@ -110,7 +110,7 @@ impl CodeSuggestion {
     }
 
     /// Returns the number of substitutions
-    pub(crate) fn substitution_spans<'a>(&'a self) -> impl Iterator<Item = Span> + 'a {
+    fn substitution_spans<'a>(&'a self) -> impl Iterator<Item = Span> + 'a {
         self.substitution_parts.iter().map(|sub| sub.span)
     }
 
@@ -492,7 +492,7 @@ impl Handler {
         self.bug(&format!("unimplemented {}", msg));
     }
 
-    pub(crate) fn bump_err_count(&self) {
+    fn bump_err_count(&self) {
         self.err_count.set(self.err_count.get() + 1);
     }
 
@@ -571,7 +571,7 @@ impl fmt::Display for Level {
 }
 
 impl Level {
-    pub(crate) fn color(self) -> term::color::Color {
+    fn color(self) -> term::color::Color {
         match self {
             Bug | Fatal | PhaseFatal | Error => term::color::BRIGHT_RED,
             Warning => {

src/librustc_lint/lib.rs

@@ -46,10 +46,10 @@ extern crate rustc_back;
 extern crate rustc_const_eval;
 extern crate syntax_pos;
 
-pub(crate) use rustc::lint;
-pub(crate) use rustc::middle;
-pub(crate) use rustc::session;
-pub(crate) use rustc::util;
+use rustc::lint;
+use rustc::middle;
+use rustc::session;
+use rustc::util;
 
 use session::Session;
 use lint::LintId;

src/librustc_llvm/lib.rs

@@ -51,7 +51,7 @@ use libc::{c_uint, c_char, size_t};
 
 pub mod archive_ro;
 pub mod diagnostic;
-pub(crate) mod ffi;
+mod ffi;
 
 pub use ffi::*;
 
@@ -120,7 +120,7 @@ impl FromStr for ArchiveKind {
 
 #[allow(missing_copy_implementations)]
 pub enum RustString_opaque {}
-pub(crate) type RustStringRef = *mut RustString_opaque;
+type RustStringRef = *mut RustString_opaque;
 type RustStringRepr = *mut RefCell<Vec<u8>>;
 
 /// Appending to a Rust string -- used by RawRustStringOstream.
@@ -199,8 +199,8 @@ impl Attribute {
 
 // Memory-managed interface to target data.
 
-pub(crate) struct TargetData {
-    pub(crate) lltd: TargetDataRef,
+struct TargetData {
+    lltd: TargetDataRef,
 }
 
 impl Drop for TargetData {
@@ -211,7 +211,7 @@ impl Drop for TargetData {
     }
 }
 
-pub(crate) fn mk_target_data(string_rep: &str) -> TargetData {
+fn mk_target_data(string_rep: &str) -> TargetData {
     let string_rep = CString::new(string_rep).unwrap();
     TargetData { lltd: unsafe { LLVMCreateTargetData(string_rep.as_ptr()) } }
 }
@@ -272,7 +272,7 @@ pub fn get_param(llfn: ValueRef, index: c_uint) -> ValueRef {
     }
 }
 
-pub(crate) fn get_params(llfn: ValueRef) -> Vec<ValueRef> {
+fn get_params(llfn: ValueRef) -> Vec<ValueRef> {
     unsafe {
         let num_params = LLVMCountParams(llfn);
         let mut params = Vec::with_capacity(num_params as usize);

src/librustc_mir/lib.rs

@@ -44,10 +44,10 @@ extern crate rustc_const_math;
 extern crate rustc_const_eval;
 extern crate core; // for NonZero
 
-pub(crate) mod diagnostics;
+mod diagnostics;
 
 mod build;
-pub(crate) mod dataflow;
+mod dataflow;
 mod hair;
 mod shim;
 pub mod transform;

src/librustc_passes/lib.rs

@@ -36,12 +36,12 @@ extern crate syntax;
 extern crate syntax_pos;
 extern crate rustc_errors as errors;
 
-pub(crate) mod diagnostics;
+mod diagnostics;
 
 pub mod ast_validation;
 pub mod consts;
 pub mod hir_stats;
 pub mod loops;
-pub(crate) mod mir_stats;
+mod mir_stats;
 pub mod no_asm;
 pub mod static_recursion;

src/librustc_plugin/lib.rs

@@ -36,7 +36,7 @@
 //! use syntax::tokenstream::TokenTree;
 //!
 //! #[plugin_registrar]
-//! pub(crate) fn plugin_registrar(reg: &mut Registry) {
+//! fn plugin_registrar(reg: &mut Registry) {
 //!     reg.register_macro("mymacro", expand_mymacro);
 //! }
 //!
@@ -80,7 +80,7 @@ extern crate rustc_errors as errors;
 
 pub use self::registry::Registry;
 
-pub(crate) mod diagnostics;
+mod diagnostics;
 pub mod registry;
 pub mod load;
 pub mod build;

src/librustc_privacy/lib.rs

@@ -41,7 +41,7 @@ use std::cmp;
 use std::mem::replace;
 use std::rc::Rc;
 
-pub(crate) mod diagnostics;
+mod diagnostics;
 
 ////////////////////////////////////////////////////////////////////////////////
 /// Visitor used to determine if pub(restricted) is used anywhere in the crate.

src/librustc_resolve/lib.rs

@@ -548,14 +548,14 @@ impl<'a> PathSource<'a> {
 }
 
 #[derive(Copy, Clone, PartialEq, Eq, Hash, Debug)]
-pub(crate) enum Namespace {
+enum Namespace {
     TypeNS,
     ValueNS,
     MacroNS,
 }
 
 #[derive(Clone, Default, Debug)]
-pub(crate) struct PerNS<T> {
+struct PerNS<T> {
     value_ns: T,
     type_ns: T,
     macro_ns: Option<T>,
@@ -827,7 +827,7 @@ enum ModuleKind {
 }
 
 /// One node in the tree of modules.
-pub(crate) struct ModuleData<'a> {
+struct ModuleData<'a> {
     parent: Option<Module<'a>>,
     kind: ModuleKind,
 
@@ -860,7 +860,7 @@ pub(crate) struct ModuleData<'a> {
     expansion: Mark,
 }
 
-pub(crate) type Module<'a> = &'a ModuleData<'a>;
+type Module<'a> = &'a ModuleData<'a>;
 
 impl<'a> ModuleData<'a> {
     fn new(parent: Option<Module<'a>>,
@@ -935,14 +935,14 @@ impl<'a> fmt::Debug for ModuleData<'a> {
 
 // Records a possibly-private value, type, or module definition.
 #[derive(Clone, Debug)]
-pub(crate) struct NameBinding<'a> {
+struct NameBinding<'a> {
     kind: NameBindingKind<'a>,
     expansion: Mark,
     span: Span,
     vis: ty::Visibility,
 }
 
-pub(crate) trait ToNameBinding<'a> {
+trait ToNameBinding<'a> {
     fn to_name_binding(self, arenas: &'a ResolverArenas<'a>) -> &'a NameBinding<'a>;
 }