Skip to content

Commit debc439

Browse files
committed
Auto merge of #33798 - locallycompact:lc/misleading-intentation, r=alexcrichton
Fix misleading intentation errors on gcc 6.0 Currently building with latest gcc results in the following error: compile: x86_64-unknown-linux-gnu/rt/miniz.o /home/lc/rust/src/rt/miniz.c: In function ‘tinfl_decompress’: /home/lc/rust/src/rt/miniz.c:578:9: error: this ‘for’ clause does not guard... [-Werror=misleading-indentation] for ( i = 0; i <= 143; ++i) *p++ = 8; for ( ; i <= 255; ++i) *p++ = 9; for ( ; i <= 279; ++i) *p++ = 7; for ( ; i <= 287; ++i) *p++ = 8; ^~~ /home/lc/rust/src/rt/miniz.c:578:47: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’ for ( i = 0; i <= 143; ++i) *p++ = 8; for ( ; i <= 255; ++i) *p++ = 9; for ( ; i <= 279; ++i) *p++ = 7; for ( ; i <= 287; ++i) *p++ = 8; ^~~ /home/lc/rust/src/rt/miniz.c: In function ‘tdefl_find_match’: /home/lc/rust/src/rt/miniz.c:1396:5: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] if (!dist) break; p = s; q = d->m_dict + probe_pos; for (probe_len = 0; probe_len < max_match_len; probe_len++) if (*p++ != *q++) break; ^~ /home/lc/rust/src/rt/miniz.c:1396:23: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ if (!dist) break; p = s; q = d->m_dict + probe_pos; for (probe_len = 0; probe_len < max_match_len; probe_len++) if (*p++ != *q++) break; ^ This patch stops this.
2 parents dd6e8d4 + 6e9774f commit debc439

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/rt/miniz.c

+8-2
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,10 @@ tinfl_status tinfl_decompress(tinfl_decompressor *r, const mz_uint8 *pIn_buf_nex
575575
{
576576
mz_uint8 *p = r->m_tables[0].m_code_size; mz_uint i;
577577
r->m_table_sizes[0] = 288; r->m_table_sizes[1] = 32; TINFL_MEMSET(r->m_tables[1].m_code_size, 5, 32);
578-
for ( i = 0; i <= 143; ++i) *p++ = 8; for ( ; i <= 255; ++i) *p++ = 9; for ( ; i <= 279; ++i) *p++ = 7; for ( ; i <= 287; ++i) *p++ = 8;
578+
for ( i = 0; i <= 143; ++i) *p++ = 8;
579+
for ( ; i <= 255; ++i) *p++ = 9;
580+
for ( ; i <= 279; ++i) *p++ = 7;
581+
for ( ; i <= 287; ++i) *p++ = 8;
579582
}
580583
else
581584
{
@@ -1393,7 +1396,10 @@ static MZ_FORCEINLINE void tdefl_find_match(tdefl_compressor *d, mz_uint lookahe
13931396
if ((d->m_dict[probe_pos + match_len] == c0) && (d->m_dict[probe_pos + match_len - 1] == c1)) break;
13941397
TDEFL_PROBE; TDEFL_PROBE; TDEFL_PROBE;
13951398
}
1396-
if (!dist) break; p = s; q = d->m_dict + probe_pos; for (probe_len = 0; probe_len < max_match_len; probe_len++) if (*p++ != *q++) break;
1399+
if (!dist) break;
1400+
p = s; q = d->m_dict + probe_pos;
1401+
for (probe_len = 0; probe_len < max_match_len; probe_len++)
1402+
if (*p++ != *q++) break;
13971403
if (probe_len > match_len)
13981404
{
13991405
*pMatch_dist = dist; if ((*pMatch_len = match_len = probe_len) == max_match_len) return;

0 commit comments

Comments
 (0)