Do not use entropy during gen_weighted_bool(1)

nagisa · nagisa · commit e723fe07783c · 2015-01-04T14:58:08.000+02:00
1 in 1 chance to return true always results in true.
diff --git a/src/librand/lib.rs b/src/librand/lib.rs
@@ -243,7 +243,7 @@ pub trait Rng : Sized {
     /// println!("{}", rng.gen_weighted_bool(3));
     /// ```
     fn gen_weighted_bool(&mut self, n: uint) -> bool {
-        n == 0 || self.gen_range(0, n) == 0
+        n <= 1 || self.gen_range(0, n) == 0
     }
 
     /// Return an iterator of random characters from the set A-Z,a-z,0-9.

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ pub trait Rng : Sized {`
`243`	`243`	`/// println!("{}", rng.gen_weighted_bool(3));`
`244`	`244`	/// ```
`245`	`245`	`fn gen_weighted_bool(&mut self, n: uint) -> bool {`
`246`		`- n == 0 \|\| self.gen_range(0, n) == 0`
	`246`	`+ n <= 1 \|\| self.gen_range(0, n) == 0`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`/// Return an iterator of random characters from the set A-Z,a-z,0-9.`