Skip to content

Commit e7b0e0a

Browse files
committed
auto merge of #10994 : ktt3ja/rust/issue-10956, r=alexcrichton
Types used inside live struct or enum are now marked live. Fix #10956 and #10993.
2 parents dc7a2e1 + fb4a1d8 commit e7b0e0a

File tree

3 files changed

+14
-0
lines changed

3 files changed

+14
-0
lines changed

src/librustc/middle/dead.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ impl MarkSymbolVisitor {
107107
match item.node {
108108
ast::item_fn(..)
109109
| ast::item_ty(..)
110+
| ast::item_enum(..)
111+
| ast::item_struct(..)
110112
| ast::item_static(..) => {
111113
visit::walk_item(self, item, ());
112114
}

src/libsyntax/visit.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,10 @@ pub fn walk_variant<E:Clone, V:Visitor<E>>(visitor:&mut V,
290290
env.clone())
291291
}
292292
}
293+
match variant.node.disr_expr {
294+
Some(expr) => visitor.visit_expr(expr, env),
295+
None => ()
296+
}
293297
}
294298

295299
pub fn skip_ty<E, V:Visitor<E>>(_: &mut V, _: &Ty, _: E) {

src/test/compile-fail/lint-dead-code-1.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ static priv_static: int = 0; //~ ERROR: code is never used
2727
static used_static: int = 0;
2828
pub static used_static2: int = used_static;
2929
static USED_STATIC: int = 0;
30+
static STATIC_USED_IN_ENUM_DISCRIMINANT: uint = 10;
3031

3132
pub type typ = ~UsedStruct4;
3233
pub struct PubStruct();
@@ -41,8 +42,15 @@ struct SemiUsedStruct;
4142
impl SemiUsedStruct {
4243
fn la_la_la() {}
4344
}
45+
struct StructUsedAsField;
46+
struct StructUsedInEnum;
47+
pub struct PubStruct2 {
48+
struct_used_as_field: *StructUsedAsField
49+
}
4450

4551
pub enum pub_enum { foo1, bar1 }
52+
pub enum pub_enum2 { a(~StructUsedInEnum) }
53+
pub enum pub_enum3 { Foo = STATIC_USED_IN_ENUM_DISCRIMINANT }
4654
enum priv_enum { foo2, bar2 } //~ ERROR: code is never used
4755
enum used_enum { foo3, bar3 }
4856

0 commit comments

Comments
 (0)