Skip to content

Commit ea8a5df

Browse files
committed
auto merge of #18044 : aturon/rust/lint-conventions, r=pcwalton
[RFC 344](rust-lang/rfcs#344) proposes a set of naming conventions for lints. This PR renames existing lints to follow the conventions. Use the following sed script to bring your code up to date: ``` s/unnecessary_typecast/unused_typecasts/g s/unsigned_negate/unsigned_negation/g s/type_limits/unused_comparisons/g s/type_overflow/overflowing_literals/g s/ctypes/improper_ctypes/g s/owned_heap_memory/box_pointers/g s/unused_attribute/unused_attributes/g s/path_statement/path_statements/g s/unused_must_use/unused_must_use/g s/unused_result/unused_results/g s/non_uppercase_statics/non_upper_case_globals/g s/unnecessary_parens/unused_parens/g s/unnecessary_import_braces/unused_import_braces/g s/unused_unsafe/unused_unsafe/g s/unsafe_block/unsafe_blocks/g s/unused_mut/unused_mut/g s/unnecessary_allocation/unused_allocation/g s/missing_doc/missing_docs/g s/unused_imports/unused_imports/g s/unused_extern_crate/unused_extern_crates/g s/unnecessary_qualification/unused_qualifications/g s/unrecognized_lint/unknown_lints/g s/unused_variable/unused_variables/g s/dead_assignment/unused_assignments/g s/unknown_crate_type/unknown_crate_types/g s/variant_size_difference/variant_size_differences/g s/transmute_fat_ptr/fat_ptr_transmutes/g ``` Since a large number of lints are being renamed for RFC 344, this PR adds some basic deprecation/renaming functionality to the pluggable lint system. It allows a simple mapping of old to new names, and can warn when old names are being used. This change needs to be rolled out in stages. In this PR, the deprecation warning is commented out, but the old name is forwarded to the new one. Once the PR lands and we have generated a new snapshot of the compiler, we can add the deprecation warning and rename all uses of the lints in the rust codebase. I will file a PR to do so. Closes #16545 Closes #17932 r? @pcwalton
2 parents af99157 + 31b7d64 commit ea8a5df

File tree

7 files changed

+191
-126
lines changed

7 files changed

+191
-126
lines changed

src/librustc/driver/driver.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -704,15 +704,15 @@ pub fn collect_crate_types(session: &Session,
704704
}
705705
Some(ref n) if n.equiv(&("bin")) => Some(config::CrateTypeExecutable),
706706
Some(_) => {
707-
session.add_lint(lint::builtin::UNKNOWN_CRATE_TYPE,
707+
session.add_lint(lint::builtin::UNKNOWN_CRATE_TYPES,
708708
ast::CRATE_NODE_ID,
709709
a.span,
710710
"invalid `crate_type` \
711711
value".to_string());
712712
None
713713
}
714714
_ => {
715-
session.add_lint(lint::builtin::UNKNOWN_CRATE_TYPE,
715+
session.add_lint(lint::builtin::UNKNOWN_CRATE_TYPES,
716716
ast::CRATE_NODE_ID,
717717
a.span,
718718
"`crate_type` requires a \

0 commit comments

Comments
 (0)