Skip to content

Commit ef90df6

Browse files
committed
Update reason why fmt-write-bloat ignores windows
1 parent 2cc029e commit ef90df6

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

tests/run-make/fmt-write-bloat/rmake.rs

+5-2
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,12 @@
1515
//! `NO_DEBUG_ASSERTIONS=1`). If debug assertions are disabled, then we can check for the absence of
1616
//! additional `usize` formatting and padding related symbols.
1717
18-
// Reason: This test is `ignore-windows` because the `no_std` test (using `#[link(name = "c")])`
19-
// doesn't link on windows.
2018
//@ ignore-windows
19+
// Reason:
20+
// - MSVC targets really need to parse the .pdb file (aka the debug information).
21+
// On Windows there's an API for that (dbghelp) which maybe we can use
22+
// - MinGW targets have a lot of symbols included in their runtime which we can't avoid.
23+
// We would need to make the symbols we're looking for more specific for this test to work.
2124
//@ ignore-cross-compile
2225

2326
use run_make_support::env::no_debug_assertions;

0 commit comments

Comments
 (0)