Skip to content

Commit f47e4b2

Browse files
committed
extratest: Fix all leaked trait imports
1 parent bcb1c38 commit f47e4b2

File tree

7 files changed

+41
-48
lines changed

7 files changed

+41
-48
lines changed

src/libextra/dlist.rs

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -625,43 +625,43 @@ impl<A: Clone> Clone for DList<A> {
625625
}
626626

627627
#[cfg(test)]
628-
pub fn check_links<T>(list: &DList<T>) {
629-
let mut len = 0u;
630-
let mut last_ptr: Option<&Node<T>> = None;
631-
let mut node_ptr: &Node<T>;
632-
match list.list_head {
633-
None => { assert_eq!(0u, list.length); return }
634-
Some(ref node) => node_ptr = &**node,
635-
}
636-
loop {
637-
match (last_ptr, node_ptr.prev.resolve_immut()) {
638-
(None , None ) => {}
639-
(None , _ ) => fail!("prev link for list_head"),
640-
(Some(p), Some(pptr)) => {
641-
assert_eq!(p as *Node<T>, pptr as *Node<T>);
642-
}
643-
_ => fail!("prev link is none, not good"),
628+
mod tests {
629+
use container::Deque;
630+
use extra::test;
631+
use std::rand;
632+
use super::{DList, Node, ListInsertion};
633+
634+
pub fn check_links<T>(list: &DList<T>) {
635+
let mut len = 0u;
636+
let mut last_ptr: Option<&Node<T>> = None;
637+
let mut node_ptr: &Node<T>;
638+
match list.list_head {
639+
None => { assert_eq!(0u, list.length); return }
640+
Some(ref node) => node_ptr = &**node,
644641
}
645-
match node_ptr.next {
646-
Some(ref next) => {
647-
last_ptr = Some(node_ptr);
648-
node_ptr = &**next;
649-
len += 1;
642+
loop {
643+
match (last_ptr, node_ptr.prev.resolve_immut()) {
644+
(None , None ) => {}
645+
(None , _ ) => fail!("prev link for list_head"),
646+
(Some(p), Some(pptr)) => {
647+
assert_eq!(p as *Node<T>, pptr as *Node<T>);
648+
}
649+
_ => fail!("prev link is none, not good"),
650650
}
651-
None => {
652-
len += 1;
653-
break;
651+
match node_ptr.next {
652+
Some(ref next) => {
653+
last_ptr = Some(node_ptr);
654+
node_ptr = &**next;
655+
len += 1;
656+
}
657+
None => {
658+
len += 1;
659+
break;
660+
}
654661
}
655662
}
663+
assert_eq!(len, list.length);
656664
}
657-
assert_eq!(len, list.length);
658-
}
659-
660-
#[cfg(test)]
661-
mod tests {
662-
use super::*;
663-
use std::rand;
664-
use extra::test;
665665

666666
#[test]
667667
fn test_basic() {

src/libextra/json.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1333,11 +1333,10 @@ impl to_str::ToStr for Error {
13331333

13341334
#[cfg(test)]
13351335
mod tests {
1336-
13371336
use super::*;
13381337

13391338
use std::io;
1340-
use serialize::Decodable;
1339+
use serialize::{Encodable, Decodable};
13411340
use treemap::TreeMap;
13421341

13431342
#[deriving(Eq, Encodable, Decodable)]

src/libextra/lib.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ Rust extras are part of the standard Rust distribution.
3434
#[deny(non_camel_case_types)];
3535
#[deny(missing_doc)];
3636

37-
pub use std::os;
38-
3937
// Utility modules
4038

4139
pub mod c_vec;
@@ -106,12 +104,4 @@ pub mod serialize;
106104
pub mod extra {
107105
pub use serialize;
108106
pub use test;
109-
110-
// For bootstrapping.
111-
pub use std::clone;
112-
pub use std::condition;
113-
pub use std::cmp;
114-
pub use std::unstable;
115-
pub use std::str;
116-
pub use std::os;
117107
}

src/libextra/num/bigint.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1434,6 +1434,7 @@ impl BigInt {
14341434
#[cfg(test)]
14351435
mod biguint_tests {
14361436
use super::*;
1437+
use super::RandBigInt;
14371438
14381439
use std::cmp::{Less, Equal, Greater};
14391440
use std::i64;
@@ -2090,6 +2091,7 @@ mod biguint_tests {
20902091
#[cfg(test)]
20912092
mod bigint_tests {
20922093
use super::*;
2094+
use super::RandBigInt;
20932095

20942096
use std::cmp::{Less, Equal, Greater};
20952097
use std::i64;

src/libextra/ringbuf.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,10 +404,11 @@ impl<A> Extendable<A> for RingBuf<A> {
404404

405405
#[cfg(test)]
406406
mod tests {
407-
use super::*;
407+
use container::Deque;
408+
use extra::test;
408409
use std::clone::Clone;
409410
use std::cmp::Eq;
410-
use extra::test;
411+
use super::RingBuf;
411412

412413
#[test]
413414
fn test_simple() {

src/libextra/stats.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,6 @@ pub fn freq_count<T: Iterator<U>, U: Eq+Hash>(mut iter: T) -> hashmap::HashMap<U
432432

433433
#[cfg(test)]
434434
mod tests {
435-
436435
use stats::Stats;
437436
use stats::Summary;
438437
use stats::write_5_number_summary;
@@ -1018,6 +1017,7 @@ mod tests {
10181017
mod bench {
10191018
use extra::test::BenchHarness;
10201019
use std::vec;
1020+
use stats::Stats;
10211021

10221022
#[bench]
10231023
fn sum_three_items(bh: &mut BenchHarness) {

src/libstd/unstable/stack.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,10 @@ static RED_ZONE: uint = 20 * 1024;
3636
// irrelevant for documentation purposes.
3737
#[cfg(not(test))] // in testing, use the original libstd's version
3838
pub extern "C" fn rust_stack_exhausted() {
39-
use rt::task::Task;
4039
use option::None;
4140
use rt::local::Local;
41+
use rt::task::Task;
42+
use str::Str;
4243
use unstable::intrinsics;
4344

4445
unsafe {

0 commit comments

Comments
 (0)