Skip to content

Commit f5c9c12

Browse files
committed
Rename b as buf in several places.
Because it's easy to confuse with `bridge`.
1 parent c2c5057 commit f5c9c12

File tree

2 files changed

+30
-30
lines changed

2 files changed

+30
-30
lines changed

library/proc_macro/src/bridge/client.rs

+16-16
Original file line numberDiff line numberDiff line change
@@ -254,17 +254,17 @@ macro_rules! define_client_side {
254254
$(impl $name {
255255
$(pub(crate) fn $method($($arg: $arg_ty),*) $(-> $ret_ty)* {
256256
Bridge::with(|bridge| {
257-
let mut b = bridge.cached_buffer.take();
257+
let mut buf = bridge.cached_buffer.take();
258258

259-
b.clear();
260-
api_tags::Method::$name(api_tags::$name::$method).encode(&mut b, &mut ());
261-
reverse_encode!(b; $($arg),*);
259+
buf.clear();
260+
api_tags::Method::$name(api_tags::$name::$method).encode(&mut buf, &mut ());
261+
reverse_encode!(buf; $($arg),*);
262262

263-
b = bridge.dispatch.call(b);
263+
buf = bridge.dispatch.call(buf);
264264

265-
let r = Result::<_, PanicMessage>::decode(&mut &b[..], &mut ());
265+
let r = Result::<_, PanicMessage>::decode(&mut &buf[..], &mut ());
266266

267-
bridge.cached_buffer = b;
267+
bridge.cached_buffer = buf;
268268

269269
r.unwrap_or_else(|e| panic::resume_unwind(e.into()))
270270
})
@@ -383,20 +383,20 @@ fn run_client<A: for<'a, 's> DecodeMut<'a, 's, ()>, R: Encode<()>>(
383383
f: impl FnOnce(A) -> R,
384384
) -> Buffer {
385385
// The initial `cached_buffer` contains the input.
386-
let mut b = bridge.cached_buffer.take();
386+
let mut buf = bridge.cached_buffer.take();
387387

388388
panic::catch_unwind(panic::AssertUnwindSafe(|| {
389389
bridge.enter(|| {
390-
let reader = &mut &b[..];
390+
let reader = &mut &buf[..];
391391
let input = A::decode(reader, &mut ());
392392

393393
// Put the `cached_buffer` back in the `Bridge`, for requests.
394-
Bridge::with(|bridge| bridge.cached_buffer = b.take());
394+
Bridge::with(|bridge| bridge.cached_buffer = buf.take());
395395

396396
let output = f(input);
397397

398398
// Take the `cached_buffer` back out, for the output value.
399-
b = Bridge::with(|bridge| bridge.cached_buffer.take());
399+
buf = Bridge::with(|bridge| bridge.cached_buffer.take());
400400

401401
// HACK(eddyb) Separate encoding a success value (`Ok(output)`)
402402
// from encoding a panic (`Err(e: PanicMessage)`) to avoid
@@ -407,16 +407,16 @@ fn run_client<A: for<'a, 's> DecodeMut<'a, 's, ()>, R: Encode<()>>(
407407
// this is defensively trying to avoid any accidental panicking
408408
// reaching the `extern "C"` (which should `abort` but might not
409409
// at the moment, so this is also potentially preventing UB).
410-
b.clear();
411-
Ok::<_, ()>(output).encode(&mut b, &mut ());
410+
buf.clear();
411+
Ok::<_, ()>(output).encode(&mut buf, &mut ());
412412
})
413413
}))
414414
.map_err(PanicMessage::from)
415415
.unwrap_or_else(|e| {
416-
b.clear();
417-
Err::<(), _>(e).encode(&mut b, &mut ());
416+
buf.clear();
417+
Err::<(), _>(e).encode(&mut buf, &mut ());
418418
});
419-
b
419+
buf
420420
}
421421

422422
impl Client<fn(crate::TokenStream) -> crate::TokenStream> {

library/proc_macro/src/bridge/server.rs

+14-14
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,15 @@ macro_rules! define_dispatcher_impl {
8080
pub trait DispatcherTrait {
8181
// HACK(eddyb) these are here to allow `Self::$name` to work below.
8282
$(type $name;)*
83-
fn dispatch(&mut self, b: Buffer) -> Buffer;
83+
fn dispatch(&mut self, buf: Buffer) -> Buffer;
8484
}
8585

8686
impl<S: Server> DispatcherTrait for Dispatcher<MarkedTypes<S>> {
8787
$(type $name = <MarkedTypes<S> as Types>::$name;)*
88-
fn dispatch(&mut self, mut b: Buffer) -> Buffer {
88+
fn dispatch(&mut self, mut buf: Buffer) -> Buffer {
8989
let Dispatcher { handle_store, server } = self;
9090

91-
let mut reader = &b[..];
91+
let mut reader = &buf[..];
9292
match api_tags::Method::decode(&mut reader, &mut ()) {
9393
$(api_tags::Method::$name(m) => match m {
9494
$(api_tags::$name::$method => {
@@ -107,12 +107,12 @@ macro_rules! define_dispatcher_impl {
107107
.map_err(PanicMessage::from)
108108
};
109109

110-
b.clear();
111-
r.encode(&mut b, handle_store);
110+
buf.clear();
111+
r.encode(&mut buf, handle_store);
112112
})*
113113
}),*
114114
}
115-
b
115+
buf
116116
}
117117
}
118118
}
@@ -141,7 +141,7 @@ impl ExecutionStrategy for SameThread {
141141
client_data: D,
142142
force_show_panics: bool,
143143
) -> Buffer {
144-
let mut dispatch = |b| dispatcher.dispatch(b);
144+
let mut dispatch = |buf| dispatcher.dispatch(buf);
145145

146146
run_client(
147147
Bridge {
@@ -175,8 +175,8 @@ impl ExecutionStrategy for CrossThread1 {
175175
let (res_tx, res_rx) = channel();
176176

177177
let join_handle = thread::spawn(move || {
178-
let mut dispatch = |b| {
179-
req_tx.send(b).unwrap();
178+
let mut dispatch = |buf| {
179+
req_tx.send(buf).unwrap();
180180
res_rx.recv().unwrap()
181181
};
182182

@@ -283,18 +283,18 @@ fn run_server<
283283
let mut dispatcher =
284284
Dispatcher { handle_store: HandleStore::new(handle_counters), server: MarkedTypes(server) };
285285

286-
let mut b = Buffer::new();
287-
input.encode(&mut b, &mut dispatcher.handle_store);
286+
let mut buf = Buffer::new();
287+
input.encode(&mut buf, &mut dispatcher.handle_store);
288288

289-
b = strategy.run_bridge_and_client(
289+
buf = strategy.run_bridge_and_client(
290290
&mut dispatcher,
291-
b,
291+
buf,
292292
run_client,
293293
client_data,
294294
force_show_panics,
295295
);
296296

297-
Result::decode(&mut &b[..], &mut dispatcher.handle_store)
297+
Result::decode(&mut &buf[..], &mut dispatcher.handle_store)
298298
}
299299

300300
impl client::Client<fn(crate::TokenStream) -> crate::TokenStream> {

0 commit comments

Comments
 (0)