Add test for unnecessary_refs lint

Author: obeis

tests/ui/consts/offset_from.rs

@@ -1,5 +1,7 @@
 //@ run-pass
 
+#![allow(unnecessary_refs)]
+
 struct Struct {
     field: (),
 }

tests/ui/lint/lint-unnecessary-refs.fixed

@@ -0,0 +1,31 @@
+//@ run-rustfix
+
+#![deny(unnecessary_refs)]
+#![allow(dead_code)]
+
+struct A {
+    a: i32,
+    b: u8,
+}
+
+fn via_ref(x: *const (i32, i32)) -> *const i32 {
+    unsafe { &raw const (*x).0 }
+    //~^ ERROR creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers [unnecessary_refs]
+}
+
+fn via_ref_struct(x: *const A) -> *const u8 {
+    unsafe { &raw const (*x).b }
+    //~^ ERROR creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers [unnecessary_refs]
+}
+
+fn via_ref_mut(x: *mut (i32, i32)) -> *mut i32 {
+    unsafe { &raw mut (*x).0 }
+    //~^ ERROR creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers [unnecessary_refs]
+}
+
+fn via_ref_struct_mut(x: *mut A) -> *mut i32 {
+    unsafe { &raw mut (*x).a }
+    //~^ ERROR creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers [unnecessary_refs]
+}
+
+fn main() {}

tests/ui/lint/lint-unnecessary-refs.rs

@@ -0,0 +1,31 @@
+//@ run-rustfix
+
+#![deny(unnecessary_refs)]
+#![allow(dead_code)]
+
+struct A {
+    a: i32,
+    b: u8,
+}
+
+fn via_ref(x: *const (i32, i32)) -> *const i32 {
+    unsafe { &(*x).0 as *const i32 }
+    //~^ ERROR creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers [unnecessary_refs]
+}
+
+fn via_ref_struct(x: *const A) -> *const u8 {
+    unsafe { &(*x).b as *const u8 }
+    //~^ ERROR creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers [unnecessary_refs]
+}
+
+fn via_ref_mut(x: *mut (i32, i32)) -> *mut i32 {
+    unsafe { &mut (*x).0 as *mut i32 }
+    //~^ ERROR creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers [unnecessary_refs]
+}
+
+fn via_ref_struct_mut(x: *mut A) -> *mut i32 {
+    unsafe { &mut (*x).a as *mut i32 }
+    //~^ ERROR creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers [unnecessary_refs]
+}
+
+fn main() {}

tests/ui/lint/lint-unnecessary-refs.stderr

@@ -0,0 +1,55 @@
+error: creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers
+  --> $DIR/lint-unnecessary-refs.rs:12:14
+   |
+LL |     unsafe { &(*x).0 as *const i32 }
+   |              ^^^^^^^^^^^^^^^^^^^^^
+   |
+note: the lint level is defined here
+  --> $DIR/lint-unnecessary-refs.rs:3:9
+   |
+LL | #![deny(unnecessary_refs)]
+   |         ^^^^^^^^^^^^^^^^
+help: consider using `&raw const` for a safer and more explicit raw pointer
+   |
+LL -     unsafe { &(*x).0 as *const i32 }
+LL +     unsafe { &raw const (*x).0 }
+   |
+
+error: creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers
+  --> $DIR/lint-unnecessary-refs.rs:17:14
+   |
+LL |     unsafe { &(*x).b as *const u8 }
+   |              ^^^^^^^^^^^^^^^^^^^^
+   |
+help: consider using `&raw const` for a safer and more explicit raw pointer
+   |
+LL -     unsafe { &(*x).b as *const u8 }
+LL +     unsafe { &raw const (*x).b }
+   |
+
+error: creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers
+  --> $DIR/lint-unnecessary-refs.rs:22:14
+   |
+LL |     unsafe { &mut (*x).0 as *mut i32 }
+   |              ^^^^^^^^^^^^^^^^^^^^^^^
+   |
+help: consider using `&raw const` for a safer and more explicit raw pointer
+   |
+LL -     unsafe { &mut (*x).0 as *mut i32 }
+LL +     unsafe { &raw mut (*x).0 }
+   |
+
+error: creating a intermediate reference implies aliasing requirements even when immediately casting to raw pointers
+  --> $DIR/lint-unnecessary-refs.rs:27:14
+   |
+LL |     unsafe { &mut (*x).a as *mut i32 }
+   |              ^^^^^^^^^^^^^^^^^^^^^^^
+   |
+help: consider using `&raw const` for a safer and more explicit raw pointer
+   |
+LL -     unsafe { &mut (*x).a as *mut i32 }
+LL +     unsafe { &raw mut (*x).a }
+   |
+
+error: aborting due to 4 previous errors
+