Skip to content

Keep space if arg does not follow punctuation when lint unused parens #138271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep space if arg does not follow punctuation when lint unused parens #138271

wants to merge 1 commit into from

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented Mar 9, 2025

Fixes #138234

If the arg follows punctuation, still pass left_pos with None and no space will be added, else then pass left_pos with Some(arg.span.lo()), so that we can add the space as expected.

And emit_unused_delims can make sure no more space will be added if the expr follows space.

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2025
@mu001999
Copy link
Contributor Author

r? compiler

@rustbot rustbot assigned compiler-errors and unassigned fmease Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False-positive unused_parens missing macro cases
4 participants
@mu001999 @rustbot @compiler-errors @fmease