Skip to content

Compiletest's "abbreviated" output can be very misleading #92211

Closed
@Aaron1011

Description

@Aaron1011

Under certain circumstances, compiletest will 'abbreviate' the output of tests:

write!(&mut head, "\n\n<<<<<< SKIPPED {} BYTES >>>>>>\n\n", skipped).unwrap();

However, the <<<<<< SKIPPED {} BYTES >>>>>> can easily be missed. I spent quite a while trying to figure out how the incremental compilation system was getting into a certain state without hitting any debug! statements, only to find out that a large chunk of the output was getting discarded.

Ideally, we would remove this 'abbreviation' logic entirely, and just ensure that our tests don't produce too much output. If it's really necessary, then we should require tests to opt in to this behavior, and fail the test if abbreviation is required when the test hasn't explicitly opted in.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions