Skip to content

Add missing urls for io types #37165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2016
Merged

Add missing urls for io types #37165

merged 1 commit into from
Oct 20, 2016

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez
Copy link
Member Author

@frewsxcv orders so I execute.

@bors: delegate=kmcallister

@bors
Copy link
Collaborator

bors commented Oct 14, 2016

✌️ @kmcallister can now approve this pull request

@kmcallister
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 15, 2016

📌 Commit e25d997 has been approved by kmcallister

ollie27
ollie27 reviewed Oct 15, 2016
View reviewed changes
src/libstd/io/cursor.rs
/// anywhere you might use a reader or writer that does actual I/O.
///
/// The standard library implements some I/O traits on various types which
/// are commonly used as a buffer, like `Cursor<Vec<u8>>` and `Cursor<&[u8]>`.
/// are commonly used as a buffer, like `Cursor<`[`Vec`]`<u8>>` and
/// `Cursor<`[`&[u8]`]`>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't put square brackets in links like this. It needs to be something like ``Cursor<[&[u8]`][bytes]`>`.` and `[bytes]: ../../std/primitive.slice.html` for this link to work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't pay attention, thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it does work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this as part of #37316.

@GuillaumeGomez
Copy link
Member Author

@bors: r-

@GuillaumeGomez
Copy link
Member Author

@bors: r=kmcallister rollup

@bors
Copy link
Collaborator

bors commented Oct 19, 2016

📌 Commit e25d997 has been approved by kmcallister

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 19, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 19, 2016
@GuillaumeGomez
Rollup merge of rust-lang#37165 - GuillaumeGomez:bytes_url, r=kmcalli…
32820c1 
…ster

Add missing urls for io types

r? @steveklabnik
bors added a commit that referenced this pull request Oct 20, 2016
@bors
Auto merge of #37289 - GuillaumeGomez:rollup, r=GuillaumeGomez
dfd98eb 
Rollup of 7 pull requests

- Successful merges: #37165, #37187, #37241, #37283, #37285, #37287, #37288
- Failed merges:
@bors bors merged commit e25d997 into rust-lang:master Oct 20, 2016
@GuillaumeGomez GuillaumeGomez deleted the bytes_url branch October 20, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollie27 ollie27 ollie27 left review comments

Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @bors @kmcallister @ollie27 @steveklabnik