rustbuild: Use Cargo's "target runner" #43534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
requested changes
Jul 29, 2017
src/libstd/process.rs
Outdated
| @@ -1418,7 +1418,8 @@ mod tests { | |||
|
|
|||
| for (ref k, ref v) in env::vars() { | |||
| // don't check android RANDOM variables | |||
| if cfg!(target_os = "android") && *k == "RANDOM" { | |||
| if cfg!(target_os = "android") && | |||
| (*k == "RANDOM" || k.contains("-")) { | |||
There was a problem hiding this comment.
This feels like it's including lots of environment variables from android systems, no? I'd definitely want a comment here..
There was a problem hiding this comment.
Oh oops right forgot to mention this, I'll add a comment.
There was a problem hiding this comment.
FWIW environment variables with - is pretty rare (most have _) and I'm just sort of randomly chalking this up to a bug in the set command which we're using to learn about environment variables.
This commit leverages a relatively new feature in Cargo to execute cross-compiled tests, the `target.$target.runner` configuration. We configure it through environment variables in rustbuild and this avoids the need for us to locate and run tests after-the-fact, instead relying on Cargo to do all that execution for us.
|
Updated! |
alexcrichton
force-pushed
the
cargo-target-runner
branch
from
5529a72 to
8e7849e
Compare
Mark-Simulacrum
approved these changes
Jul 29, 2017
|
@bors r+ |
|
📌 Commit 8e7849e has been approved by |
bors
added a commit
that referenced
this pull request
Jul 29, 2017
…acrum rustbuild: Use Cargo's "target runner" This commit leverages a relatively new feature in Cargo to execute cross-compiled tests, the `target.$target.runner` configuration. We configure it through environment variables in rustbuild and this avoids the need for us to locate and run tests after-the-fact, instead relying on Cargo to do all that execution for us.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit leverages a relatively new feature in Cargo to execute
cross-compiled tests, the
target.$target.runnerconfiguration. We configure itthrough environment variables in rustbuild and this avoids the need for us to
locate and run tests after-the-fact, instead relying on Cargo to do all that
execution for us.