Skip to content

Add std::fmt::Pointer implementation for AtomicPtr #46647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

Add std::fmt::Pointer implementation for AtomicPtr #46647

merged 1 commit into from
Dec 12, 2017

Conversation

varkor
Copy link
Member

@varkor varkor commented Dec 10, 2017

Resolves #29212.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @bluss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2017
@sfackler
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Dec 11, 2017

📌 Commit e4dc11d has been approved by sfackler

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2017
@kennytm
Copy link
Member

kennytm commented Dec 11, 2017

@bors rollup

@bors
Copy link
Collaborator

bors commented Dec 12, 2017

⌛ Testing commit e4dc11d with merge 707d070...

bors added a commit that referenced this pull request Dec 12, 2017
@bors
Auto merge of #46647 - varkor:contrib-1, r=sfackler
707d070 
Add `std::fmt::Pointer` implementation for `AtomicPtr`

Resolves #29212.
@bors
Copy link
Collaborator

bors commented Dec 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 707d070 to master...

@bors bors merged commit e4dc11d into rust-lang:master Dec 12, 2017
@varkor varkor deleted the contrib-1 branch December 12, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bluss bluss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@varkor @rust-highfive @sfackler @bors @kennytm @bluss