Add docs note about Any::type_id on smart pointers
#79870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @shepmaster (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@sharnoff I edited the PR description so this closes the issue once merged. |
camelid
added
A-docs
Cool, thanks! |
Co-authored-by: Camelid <[email protected]>
|
Hey @camelid - what are the next steps for this? |
|
You'll have to wait for your assigned reviewer, shepmaster, to review this. Sometimes reviews can take up to 10-15 days because people may have full-time jobs and/or a lot of other commitments. |
|
Cool, makes sense - thanks! |
|
@bors r+ rollup Thanks! |
|
📌 Commit 72a7f73 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79868.
There's an issue I've run into a couple times while using values of type
Box<dyn Any>- essentially, callingvalue.type_id()doesn't dereference to the trait object, but uses the implementation ofAnyforBox<dyn Any>, giving us theTypeIdof the container instead of the object inside it.I couldn't find any notes about this in the documentation and - while it could be inferred from existing knowledge of Rust and the blanket implemenation of
Any- I think it'd be nice to have a note about it in the documentation for theanymodule.Anyways, here's a first draft of a section about it. I'm happy to revise wording :)