Skip to content

Commit 3394e16

Browse files
authored
Earlier clarification of pFCP abbreviation (#791)
1 parent 745c831 commit 3394e16

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/implementing_new_features.md

+7-6
Original file line numberDiff line numberDiff line change
@@ -20,23 +20,24 @@ process (e.g. a big refactoring of the code, or a
2020
amounts to a small feature) but is still too controversial or
2121
big to get by with a single r+, you can start a pFCP (or, if you
2222
don't have r+ rights, ask someone who has them to start one - and
23-
unless they have a concern themselves, they should).
23+
unless they have a concern themselves, they should). pFCP stands for
24+
"proposed final comment period".
2425

2526
Again, the pFCP process is only needed if you need consensus - if you
2627
don't think anyone would have a problem with your change, it's ok to
2728
get by with only an r+. For example, it is OK to add or modify
28-
unstable command-line flags or attributes without an pFCP for
29+
unstable command-line flags or attributes without a pFCP for
2930
compiler development or standard library use, as long as you don't
3031
expect them to be in wide use in the nightly ecosystem.
3132

3233
You don't need to have the implementation fully ready for r+ to ask
3334
for a pFCP, but it is generally a good idea to have at least a proof
3435
of concept so that people can see what you are talking about.
3536

36-
That starts a "proposed final comment period" (pFCP), which requires
37-
all members of the team to sign off the FCP. After they all do so,
38-
there's a 10 day long "final comment period" where everybody can comment,
39-
and if no new concerns are raised, the PR/issue gets FCP approval.
37+
When a pFCP is started, it requires all members of the team to sign off
38+
the FCP. After they all do so, there's a 10 day long "final comment
39+
period" where everybody can comment, and if no new concerns are raised,
40+
the PR/issue gets FCP approval.
4041

4142
## The logistics of writing features
4243

0 commit comments

Comments
 (0)