Skip to content

Commit 0f5e94d

Browse files
KobzolKobzol
authored
Merge pull request #2007 from Mark-Simulacrum/triage
Triage for this week
2 parents 61d457d + c1be5da commit 0f5e94d

File tree

1 file changed

+100
-0
lines changed

1 file changed

+100
-0
lines changed

‎triage/2024-11-11.md

Lines changed: 100 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,100 @@
1+
# 2024-11-11 Triage Log
2+
3+
Regressions primarily in doc builds. No significant changes in cycle or max-rss
4+
counts.
5+
6+
Triage done by **@simulacrum**.
7+
Revision range: [27e38f8f..d4822c2d](https://perf.rust-lang.org/?start=27e38f8fc7efc57b75e9a763d7a0ee44822cd5f7&end=d4822c2d84c242cc7403118b50c571464f38ef8f&absolute=false&stat=instructions%3Au)
8+
9+
**Summary**:
10+
11+
| (instructions:u) | mean | range | count |
12+
|:----------------------------------:|:-----:|:--------------:|:-----:|
13+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 1.0%] | 61 |
14+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.2%, 1.5%] | 30 |
15+
| Improvements ✅ <br /> (primary) | -2.9% | [-5.0%, -0.6%] | 7 |
16+
| Improvements ✅ <br /> (secondary) | -1.5% | [-5.0%, -0.2%] | 28 |
17+
| All ❌✅ (primary) | 0.1% | [-5.0%, 1.0%] | 68 |
18+
19+
1 Regressions, 1 Improvements, 4 Mixed; 1 of them in rollups
20+
47 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Clean middle generics using paren sugar if trait has `#[rustc_paren_sugar]` [#132697](https://github.com/rust-lang/rust/pull/132697) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4d215e2426d52ca8d1af166d5f6b5e172afbff67&end=116fc31c5c82b7767c87101164a1afa3faea97fd&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.4%] | 8 |
29+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 16 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.4%] | 8 |
33+
34+
Doc-only regressions, no fix directly planned (prioritizing code clarity), but
35+
inspired some unrelated cleanup in
36+
https://github.com/rust-lang/rust/pull/132886.
37+
38+
rustdoc-search: simplify rules for generics and type params [#127589](https://github.com/rust-lang/rust/pull/127589) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=71042b4b201a432b426304f511b3169850ed8923&end=d4822c2d84c242cc7403118b50c571464f38ef8f&stat=instructions:u)
39+
40+
| (instructions:u) | mean | range | count |
41+
|:----------------------------------:|:-----:|:--------------:|:-----:|
42+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.5%] | 15 |
43+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 0.5%] | 19 |
44+
| Improvements ✅ <br /> (primary) | - | - | 0 |
45+
| Improvements ✅ <br /> (secondary) | -2.4% | [-2.4%, -2.4%] | 1 |
46+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.5%] | 15 |
47+
48+
Doc-only regressions, likely genuine given the change.
49+
50+
#### Improvements
51+
52+
Only disable cache if predicate has opaques within it [#132625](https://github.com/rust-lang/rust/pull/132625) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8549802939cd01111c46e34a7b67cb1933977af9&end=c07aa1e17199e27f6f7ac8f3307bca7bda0084b6&stat=instructions:u)
53+
54+
| (instructions:u) | mean | range | count |
55+
|:----------------------------------:|:-----:|:--------------:|:-----:|
56+
| Regressions ❌ <br /> (primary) | - | - | 0 |
57+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
58+
| Improvements ✅ <br /> (primary) | -2.7% | [-5.0%, -0.2%] | 7 |
59+
| Improvements ✅ <br /> (secondary) | -3.0% | [-5.1%, -0.3%] | 10 |
60+
| All ❌✅ (primary) | -2.7% | [-5.0%, -0.2%] | 7 |
61+
62+
#### Mixed
63+
64+
Add new unstable feature `const_eq_ignore_ascii_case` [#131721](https://github.com/rust-lang/rust/pull/131721) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e1fb28856267e3cbfd1ea479e666ce25d67fea29&end=279604832887abeaea0cb31c20590c43dea497ae&stat=instructions:u)
65+
66+
| (instructions:u) | mean | range | count |
67+
|:----------------------------------:|:-----:|:--------------:|:-----:|
68+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
69+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
70+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.7%, -0.1%] | 4 |
71+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
72+
| All ❌✅ (primary) | -0.3% | [-0.7%, 0.2%] | 5 |
73+
74+
Probably mostly luck of some kind, change itself is library-only.
75+
76+
Emit warning when calling/declaring functions with unavailable vectors. [#132173](https://github.com/rust-lang/rust/pull/132173) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=303fc0527aea5c7e9bbef97da926639e1ade3399&end=7660aed73d5233fdd1ff2651fc8a6acab1b61691&stat=instructions:u)
77+
78+
| (instructions:u) | mean | range | count |
79+
|:----------------------------------:|:-----:|:--------------:|:-----:|
80+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 1.0%] | 36 |
81+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.2%, 0.9%] | 6 |
82+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
83+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
84+
| All ❌✅ (primary) | 0.5% | [-0.4%, 1.0%] | 37 |
85+
86+
Regression, but a bunch of optimization work already went into it (see
87+
https://github.com/rust-lang/rust/pull/132173#issuecomment-2466642549).
88+
89+
Rollup of 6 pull requests [#132831](https://github.com/rust-lang/rust/pull/132831) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7660aed73d5233fdd1ff2651fc8a6acab1b61691&end=668959740f97e7a22ae340742886d330ab63950f&stat=instructions:u)
90+
91+
| (instructions:u) | mean | range | count |
92+
|:----------------------------------:|:-----:|:--------------:|:-----:|
93+
| Regressions ❌ <br /> (primary) | - | - | 0 |
94+
| Regressions ❌ <br /> (secondary) | 1.4% | [1.3%, 1.5%] | 6 |
95+
| Improvements ✅ <br /> (primary) | - | - | 0 |
96+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.4%, -0.2%] | 13 |
97+
| All ❌✅ (primary) | - | - | 0 |
98+
99+
Queued up one trial build. Likely a real regression, but not necessarily worth
100+
digging deeper given limited impact (few benchmarks).

0 commit comments

Comments
 (0)