Skip to content

Commit 1744325

Browse files
Mark-SimulacrumMark-Simulacrum
authored
Add 2023-08-29 triage (#1711)
1 parent 3dc219c commit 1744325

File tree

1 file changed

+120
-0
lines changed

1 file changed

+120
-0
lines changed

‎triage/2023-08-29.md

+120
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,120 @@
1+
# 2023-08-29 Triage Log
2+
3+
A fairly quiet week, with improvements exceeding a small scattering of
4+
regressions. Memory usage and artifact size held fairly steady across the week,
5+
with no regressions or improvements.
6+
7+
Triage done by **@simulacrum**.
8+
Revision range: [d4a881e1433cd10e424843353e1f939f5a798f4e..cedbe5c715c1fa9359683c5f108bed2054ac258b](https://perf.rust-lang.org/?start=d4a881e1433cd10e424843353e1f939f5a798f4e&end=cedbe5c715c1fa9359683c5f108bed2054ac258b&absolute=false&stat=instructions%3Au)
9+
10+
**Summary**:
11+
12+
| (instructions:u) | mean | range | count |
13+
|:----------------------------------:|:-----:|:--------------:|:-----:|
14+
| Regressions ❌ <br /> (primary) | 1.6% | [0.3%, 2.2%] | 6 |
15+
| Regressions ❌ <br /> (secondary) | 1.4% | [0.8%, 1.9%] | 19 |
16+
| Improvements ✅ <br /> (primary) | -1.0% | [-8.0%, -0.3%] | 70 |
17+
| Improvements ✅ <br /> (secondary) | -1.6% | [-4.2%, -0.2%] | 56 |
18+
| All ❌✅ (primary) | -0.8% | [-8.0%, 2.2%] | 76 |
19+
20+
21+
2 Regressions, 3 Improvements, 2 Mixed; 0 of them in rollups
22+
108 artifact comparisons made in total
23+
24+
#### Regressions
25+
26+
rustdoc: Add lint `redundant_explicit_links` [#113167](https://github.com/rust-lang/rust/pull/113167) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f32ced648191cc67efdf6001585687ad22ed00d2&end=9c699a40cc2680b876c32ee69b402ee34bf7989a&stat=instructions:u)
27+
28+
| (instructions:u) | mean | range | count |
29+
|:----------------------------------:|:----:|:------------:|:-----:|
30+
| Regressions ❌ <br /> (primary) | 0.7% | [0.4%, 0.9%] | 7 |
31+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
32+
| Improvements ✅ <br /> (primary) | - | - | 0 |
33+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
34+
| All ❌✅ (primary) | 0.7% | [0.4%, 0.9%] | 7 |
35+
36+
Small regression in libc compilation, primarily incremental non-doc scenarios.
37+
Unclear cause but sufficiently limited in scope that further investigation is
38+
not warranted.
39+
40+
Fix races conditions with `SyntaxContext` decoding [#115082](https://github.com/rust-lang/rust/pull/115082) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aa5dbee3ebff8703456e8be3b5fb368fc68fe0d1&end=b60e31b673b0d36c50f8e0a3b6f8f077221d983d&stat=instructions:u)
41+
42+
| (instructions:u) | mean | range | count |
43+
|:----------------------------------:|:----:|:------------:|:-----:|
44+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 4 |
45+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.4%] | 7 |
46+
| Improvements ✅ <br /> (primary) | - | - | 0 |
47+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
48+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.3%] | 4 |
49+
50+
Some small regressions, but this is a correctness fix for parallel compilation
51+
so warranted. (Parallel compilation is not on here but the fix affects both
52+
non-parallel and parallel scenarios).
53+
54+
#### Improvements
55+
56+
Speed up compilation of `type-system-chess` [#114611](https://github.com/rust-lang/rust/pull/114611) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fe3eae3f310b2f709aa5b39d76a94fc1ea843854&end=a1e1dba9cc40a90409bccb8b19e359c4bdf573e5&stat=instructions:u)
57+
58+
| (instructions:u) | mean | range | count |
59+
|:----------------------------------:|:-----:|:--------------:|:-----:|
60+
| Regressions ❌ <br /> (primary) | - | - | 0 |
61+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
62+
| Improvements ✅ <br /> (primary) | -1.7% | [-1.7%, -1.7%] | 1 |
63+
| Improvements ✅ <br /> (secondary) | -2.2% | [-4.2%, -0.7%] | 28 |
64+
| All ❌✅ (primary) | -1.7% | [-1.7%, -1.7%] | 1 |
65+
66+
> Perf results look good, various small improvements in secondary benchmarks.
67+
> The real driver was the type-system-chess program I mentioned above, where
68+
> the walltime and max-rss changes were both about -85% when I measured them
69+
> locally.
70+
71+
(https://github.com/rust-lang/rust/pull/114611#issuecomment-1670713067)
72+
73+
Add MIR validation for unwind out from nounwind functions + fixes to make validation pass [#113124](https://github.com/rust-lang/rust/pull/113124) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b6ab01a7131481b52131a9bd814dc8084052f643&end=ff55fa30267d7963146c52026b4f4f5396484675&stat=instructions:u)
74+
75+
| (instructions:u) | mean | range | count |
76+
|:----------------------------------:|:-----:|:--------------:|:-----:|
77+
| Regressions ❌ <br /> (primary) | - | - | 0 |
78+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
79+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.1%, -0.5%] | 6 |
80+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.6%, -0.2%] | 3 |
81+
| All ❌✅ (primary) | -0.7% | [-1.1%, -0.5%] | 6 |
82+
83+
84+
Update x64 Linux host compiler to LLVM 17 [#114297](https://github.com/rust-lang/rust/pull/114297) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9bd60a60cefdddca1f507083dda37e1664b295c5&end=0b31792ef1c15538b07c7b83585dc2fb371c239f&stat=instructions:u)
85+
86+
| (instructions:u) | mean | range | count |
87+
|:----------------------------------:|:-----:|:--------------:|:-----:|
88+
| Regressions ❌ <br /> (primary) | - | - | 0 |
89+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
90+
| Improvements ✅ <br /> (primary) | -0.6% | [-1.0%, -0.2%] | 41 |
91+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.5%, -0.2%] | 22 |
92+
| All ❌✅ (primary) | -0.6% | [-1.0%, -0.2%] | 41 |
93+
94+
95+
#### Mixed
96+
97+
Remove references in VarDebugInfo [#114904](https://github.com/rust-lang/rust/pull/114904) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=07688726805d5db0a4bca445a6651d09708041ea&end=ccc3ac0cae0d901a360c4f93f6d41d87ed459d20&stat=instructions:u)
98+
99+
| (instructions:u) | mean | range | count |
100+
|:----------------------------------:|:-----:|:--------------:|:-----:|
101+
| Regressions ❌ <br /> (primary) | 0.8% | [0.3%, 1.3%] | 10 |
102+
| Regressions ❌ <br /> (secondary) | 1.4% | [1.3%, 1.4%] | 4 |
103+
| Improvements ✅ <br /> (primary) | -1.0% | [-7.3%, -0.3%] | 32 |
104+
| Improvements ✅ <br /> (secondary) | -2.1% | [-2.4%, -1.6%] | 4 |
105+
| All ❌✅ (primary) | -0.6% | [-7.3%, 1.3%] | 42 |
106+
107+
Fixed a bug in codegen. The regressions appear to be within noise range for the
108+
relevant benchmarks.
109+
110+
Add a new helper to avoid calling io::Error::kind [#115228](https://github.com/rust-lang/rust/pull/115228) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c5035271acc7e140893c1dcdb5a83bf4ddf04593&end=9334ec93541fd6963a3bfa2d2d09e3e33ac93131&stat=instructions:u)
111+
112+
| (instructions:u) | mean | range | count |
113+
|:----------------------------------:|:-----:|:--------------:|:-----:|
114+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
115+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
116+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.8%, -0.5%] | 3 |
117+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
118+
| All ❌✅ (primary) | -0.4% | [-0.8%, 0.3%] | 4 |
119+
120+
Regression is within noise range of the relevant benchmark.

0 commit comments

Comments
 (0)