Skip to content

Commit 283c645

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent c982583 commit 283c645

File tree

1 file changed

+152
-0
lines changed

1 file changed

+152
-0
lines changed

‎triage/2024-05-06.md

Lines changed: 152 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,152 @@
1+
# 2024-05-07 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [c65b2dc9..69f53f5e](https://perf.rust-lang.org/?start=c65b2dc935c27c0c8c3997c6e8d8894718a2cb1a&end=69f53f5e5583381267298ac182eb02c7f1b5c1cd&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 3.0% | [0.2%, 19.5%] | 65 |
13+
| Regressions ❌ <br /> (secondary) | 1.3% | [0.2%, 4.5%] | 103 |
14+
| Improvements ✅ <br /> (primary) | -0.9% | [-2.2%, -0.2%] | 24 |
15+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.4%, -0.4%] | 23 |
16+
| All ❌✅ (primary) | 1.9% | [-2.2%, 19.5%] | 89 |
17+
18+
19+
3 Regressions, 2 Improvements, 3 Mixed; 5 of them in rollups
20+
54 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 7 pull requests [#124675](https://github.com/rust-lang/rust/pull/124675) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0d7b2fb797f214ea7514cfeaf2caef8178d8e3fc&end=befabbc9e5f6e82e659f9f52040ee0dd40593d8a&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 1.2%] | 11 |
29+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.4%, 1.3%] | 17 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.5% | [0.2%, 1.2%] | 11 |
33+
34+
35+
Update cargo [#124684](https://github.com/rust-lang/rust/pull/124684) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=09cd00fea4aecaa6707f122d7e143196b8a12ee2&end=2c4bf249bd47f232de3c1e78ffe69b40c29bfcca&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:-------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 2.4% | [0.2%, 19.1%] | 83 |
40+
| Regressions ❌ <br /> (secondary) | 1.6% | [0.2%, 5.7%] | 92 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 2.4% | [0.2%, 19.1%] | 83 |
44+
45+
46+
Rollup of 3 pull requests [#124784](https://github.com/rust-lang/rust/pull/124784) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=96f1da82687f499dd3f57006ae71548714532382&end=d287f3e4eeaf680e8fe875f1ec75cca68f357d30&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 5 |
51+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 5 |
55+
56+
57+
#### Improvements
58+
59+
Rollup of 10 pull requests [#124646](https://github.com/rust-lang/rust/pull/124646) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=79734f1db8dbe322192dea32c0f6b80ab14c4c1d&end=561b5dea1e7e5c21f0fb550ca579229ceb878297&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | -1.0% | [-2.8%, -0.2%] | 24 |
66+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.6%, -0.3%] | 9 |
67+
| All ❌✅ (primary) | -1.0% | [-2.8%, -0.2%] | 24 |
68+
69+
70+
Some hir cleanups [#124401](https://github.com/rust-lang/rust/pull/124401) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d2d24e395a1e4fcee62ca17bf4cbddb1f903af97&end=09cd00fea4aecaa6707f122d7e143196b8a12ee2&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.2%, -0.1%] | 3 |
77+
| Improvements ✅ <br /> (secondary) | -1.1% | [-2.0%, -0.2%] | 2 |
78+
| All ❌✅ (primary) | -0.1% | [-0.2%, -0.1%] | 3 |
79+
80+
81+
#### Mixed
82+
83+
Account for immutably borrowed locals in MIR copy-prop and GVN [#123602](https://github.com/rust-lang/rust/pull/123602) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=befabbc9e5f6e82e659f9f52040ee0dd40593d8a&end=d2d24e395a1e4fcee62ca17bf4cbddb1f903af97&stat=instructions:u)
84+
85+
| (instructions:u) | mean | range | count |
86+
|:----------------------------------:|:-----:|:--------------:|:-----:|
87+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.9%] | 10 |
88+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 2.6%] | 4 |
89+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.1%, -0.2%] | 6 |
90+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.0%, -0.3%] | 8 |
91+
| All ❌✅ (primary) | 0.0% | [-1.1%, 0.9%] | 16 |
92+
93+
94+
Rollup of 8 pull requests [#124703](https://github.com/rust-lang/rust/pull/124703) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7dd170fccb3be6b1737af5df14dd736b366236c1&end=d7ea27808deb5e10a0f7384e339e4e6165e33398&stat=instructions:u)
95+
96+
| (instructions:u) | mean | range | count |
97+
|:----------------------------------:|:-----:|:--------------:|:-----:|
98+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 0.6%] | 4 |
99+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
100+
| Improvements ✅ <br /> (primary) | - | - | 0 |
101+
| Improvements ✅ <br /> (secondary) | -1.0% | [-1.5%, -0.5%] | 4 |
102+
| All ❌✅ (primary) | 0.5% | [0.2%, 0.6%] | 4 |
103+
104+
105+
Rollup of 4 pull requests [#124716](https://github.com/rust-lang/rust/pull/124716) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1a851da73cdeb02e2c62d301aa6bd98e515a50da&end=d568423a7a4ddb4b49323d96078a22f94df55fbd&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | - | - | 0 |
110+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.5%] | 6 |
111+
| Improvements ✅ <br /> (primary) | -0.8% | [-0.8%, -0.8%] | 1 |
112+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
113+
| All ❌✅ (primary) | -0.8% | [-0.8%, -0.8%] | 1 |
114+
115+
116+
#### Untriaged Pull Requests
117+
118+
- [#124784 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/124784)
119+
- [#124716 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/124716)
120+
- [#124700 Remove an unnecessary cast](https://github.com/rust-lang/rust/pull/124700)
121+
- [#124684 Update cargo](https://github.com/rust-lang/rust/pull/124684)
122+
- [#124675 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/124675)
123+
- [#124241 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/124241)
124+
- [#123909 Stabilize `Utf8Chunks`](https://github.com/rust-lang/rust/pull/123909)
125+
- [#123602 Account for immutably borrowed locals in MIR copy-prop and GVN](https://github.com/rust-lang/rust/pull/123602)
126+
- [#123147 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/123147)
127+
- [#122976 Remove len argument from RawVec::reserve_for_push](https://github.com/rust-lang/rust/pull/122976)
128+
- [#122900 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/122900)
129+
- [#122671 Codegen const panic messages as function calls](https://github.com/rust-lang/rust/pull/122671)
130+
- [#122396 Less generic code for Vec allocations](https://github.com/rust-lang/rust/pull/122396)
131+
- [#121955 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/121955)
132+
- [#121804 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/121804)
133+
- [#121752 Detect unused struct impls pub trait](https://github.com/rust-lang/rust/pull/121752)
134+
- [#121462 Combine `Sub` and `Equate`](https://github.com/rust-lang/rust/pull/121462)
135+
- [#121345 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/121345)
136+
- [#120985 Update host LLVM on x64 Linux to LLVM 18](https://github.com/rust-lang/rust/pull/120985)
137+
- [#120863 Use intrinsics::debug_assertions in debug_assert_nounwind](https://github.com/rust-lang/rust/pull/120863)
138+
- [#120862 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/120862)
139+
- [#120809 Use `transmute_unchecked` in `NonZero::new`.](https://github.com/rust-lang/rust/pull/120809)
140+
- [#120588 wasm: Store rlib metadata in wasm object files](https://github.com/rust-lang/rust/pull/120588)
141+
- [#120504 Vec::try_with_capacity](https://github.com/rust-lang/rust/pull/120504)
142+
- [#120401 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/120401)
143+
- [#120335 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/120335)
144+
- [#119662 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/119662)
145+
- [#119204 macro_rules: Less hacky heuristic for using `tt` metavariable spans](https://github.com/rust-lang/rust/pull/119204)
146+
- [#119002 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/119002)
147+
- [#118661 Restore `const PartialEq`](https://github.com/rust-lang/rust/pull/118661)
148+
149+
#### Nags requiring follow up
150+
151+
TODO: Nags
152+

0 commit comments

Comments
 (0)