Skip to content

Commit 42fd135

Browse files
Better error reporting from triage script
1 parent 23e84d9 commit 42fd135

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

triage/weekly_report.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,16 +240,20 @@ def make_request_payload(start, end):
240240

241241

242242
def make_request(start, end):
243-
# FIXME: Add some sort of retry mechanism
243+
# Retry request twice
244+
try:
245+
req = urllib.request.Request('https://perf.rust-lang.org/perf/get')
246+
except:
247+
req = urllib.request.Request('https://perf.rust-lang.org/perf/get')
244248

245-
req = urllib.request.Request('https://perf.rust-lang.org/perf/get')
246249
req.add_header('Content-Type', 'application/json')
247250
req.data = make_request_payload(start, end)
248251
with urllib.request.urlopen(req) as f:
249252
data = msgpack.unpack(f, raw=False)
250253
return data
251254

252255

256+
253257
def do_triage(start, end):
254258
# Get the next commit after `start` by comparing it with itself
255259
initial_response = make_request(start, start)
@@ -264,7 +268,10 @@ def do_triage(start, end):
264268
try:
265269
response = make_request(*commits)
266270
except urllib.error.HTTPError as e:
271+
eprint(f"Failed to make request for {commits[0]} and {commits[1]}")
267272
eprint(e)
273+
eprint("URL: " + e.geturl())
274+
eprint("Data: " + e.read().decode())
268275
break
269276

270277
if not response['is_contiguous']:

0 commit comments

Comments
 (0)