Skip to content

Commit 70f12d4

Browse files
pnkfelixpnkfelix
committed
triage report for today.
1 parent ef9fc5f commit 70f12d4

File tree

1 file changed

+191
-0
lines changed

1 file changed

+191
-0
lines changed

‎triage/2023-01-18.md

+191
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,191 @@
1+
# 2023-01-18 Triage Log
2+
3+
Nearly all flagged regressions are likely noise, except one rollup with minor
4+
impact on diesel that we will follow up on. We had a broad (albeit small) win
5+
from [#106294](https://github.com/rust-lang/rust/pull/106294).
6+
7+
Triage done by **@pnkfelix**.
8+
Revision range: [0442fbabe24ec43636a80ad1f40a0ad92a2e38df..1f72129ffe5e8c495113f9a2d4e1730f7fad3209](https://perf.rust-lang.org/?start=0442fbabe24ec43636a80ad1f40a0ad92a2e38df&end=1f72129ffe5e8c495113f9a2d4e1730f7fad3209&absolute=false&stat=instructions%3Au)
9+
10+
**Summary**:
11+
12+
| (instructions:u) | mean | range | count |
13+
|:----------------------------------:|:-----:|:--------------:|:-----:|
14+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 1.7%] | 39 |
15+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 1.8%] | 23 |
16+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.2%] | 7 |
17+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.6%, -0.2%] | 6 |
18+
| All ❌✅ (primary) | 0.3% | [-0.6%, 1.7%] | 46 |
19+
20+
21+
4 Regressions, 3 Improvements, 3 Mixed; 4 of them in rollups
22+
50 artifact comparisons made in total
23+
24+
#### Regressions
25+
26+
Rollup of 9 pull requests [#106730](https://github.com/rust-lang/rust/pull/106730) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b22c152958eade17a71d899b29a2d39bcc77aa48&end=ef4046e4f3932991971cdb64915172899532aece&stat=instructions:u)
27+
28+
| (instructions:u) | mean | range | count |
29+
|:----------------------------------:|:----:|:------------:|:-----:|
30+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 6 |
31+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.7%] | 4 |
32+
| Improvements ✅ <br /> (primary) | - | - | 0 |
33+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
34+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.3%] | 6 |
35+
36+
* already isolated by the PR author to [#106321](https://github.com/rust-lang/rust/issues/106321)
37+
* left comment and marked as triaged
38+
39+
Rollup of 10 pull requests [#106822](https://github.com/rust-lang/rust/pull/106822) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0b90256ada21c6a81b4c18f2c7a23151ab5fc232&end=a11eb4f267ddfe4f00cb40bf94aef508c11e0862&stat=instructions:u)
40+
41+
| (instructions:u) | mean | range | count |
42+
|:----------------------------------:|:----:|:------------:|:-----:|
43+
| Regressions ❌ <br /> (primary) | 0.8% | [0.8%, 0.9%] | 4 |
44+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 0.8%] | 12 |
45+
| Improvements ✅ <br /> (primary) | - | - | 0 |
46+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
47+
| All ❌✅ (primary) | 0.8% | [0.8%, 0.9%] | 4 |
48+
49+
* the sole primary impacted benchmarks are variants of helloworld-check.
50+
* Looking at the [graph](https://perf.rust-lang.org/index.html?start=2022-12-14&end=2023-01-17&benchmark=helloworld&profile=check&scenario=incr-unchanged&stat=instructions:u), I'm categorizing this as noise.
51+
* left comment and marked as triaged
52+
53+
Rework some `predicates_of`/`{Generic,Instantiated}Predicates` code [#106395](https://github.com/rust-lang/rust/pull/106395) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=41edaac716dde55b6a9d83ae4da0fba354ae5ba8&end=d12412c90fbd974b1cf886e42a95c850d9ee45a1&stat=instructions:u)
54+
55+
| (instructions:u) | mean | range | count |
56+
|:----------------------------------:|:-----:|:--------------:|:-----:|
57+
| Regressions ❌ <br /> (primary) | 0.8% | [0.7%, 0.9%] | 4 |
58+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.2%, 1.1%] | 18 |
59+
| Improvements ✅ <br /> (primary) | - | - | 0 |
60+
| Improvements ✅ <br /> (secondary) | -0.7% | [-0.7%, -0.7%] | 1 |
61+
| All ❌✅ (primary) | 0.8% | [0.7%, 0.9%] | 4 |
62+
63+
* already triaged as noise
64+
65+
Heuristically undo path prefix mappings. [#106853](https://github.com/rust-lang/rust/pull/106853) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=af669c26846f85fd15e34a6f03d5d2f237444c17&end=481725984b4cd94ef5c00917b01c1771b6e5299c&stat=instructions:u)
66+
67+
| (instructions:u) | mean | range | count |
68+
|:----------------------------------:|:----:|:------------:|:-----:|
69+
| Regressions ❌ <br /> (primary) | 0.7% | [0.7%, 0.8%] | 3 |
70+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.6%] | 9 |
71+
| Improvements ✅ <br /> (primary) | - | - | 0 |
72+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
73+
| All ❌✅ (primary) | 0.7% | [0.7%, 0.8%] | 3 |
74+
75+
* From the [graph](https://perf.rust-lang.org/index.html?start=2022-12-17&end=2023-01-18&benchmark=helloworld&profile=check&scenario=incr-unchanged&stat=instructions:u), I think this is just noise
76+
* left comment and marked as triaged
77+
78+
79+
#### Improvements
80+
81+
Update cargo [#106825](https://github.com/rust-lang/rust/pull/106825) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a11eb4f267ddfe4f00cb40bf94aef508c11e0862&end=ca5d92d789c94060fc32bfc4a778fb16904756ea&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.9% | [-0.9%, -0.8%] | 4 |
88+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.8%, -0.3%] | 12 |
89+
| All ❌✅ (primary) | -0.9% | [-0.9%, -0.8%] | 4 |
90+
91+
* just noise in the other direction
92+
93+
Emit only one nbsp error per file [#106872](https://github.com/rust-lang/rust/pull/106872) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d12412c90fbd974b1cf886e42a95c850d9ee45a1&end=a5bfc25c93d2549887848529382892f93c95207d&stat=instructions:u)
94+
95+
| (instructions:u) | mean | range | count |
96+
|:----------------------------------:|:-----:|:--------------:|:-----:|
97+
| Regressions ❌ <br /> (primary) | - | - | 0 |
98+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
99+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.8%, -0.7%] | 4 |
100+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.1%, -0.3%] | 15 |
101+
| All ❌✅ (primary) | -0.7% | [-0.8%, -0.7%] | 4 |
102+
103+
* just noise in the other direction
104+
105+
106+
Put `noundef` on all scalars that don't allow uninit [#106294](https://github.com/rust-lang/rust/pull/106294) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=38a76f33220c4b9d13dda1fa8f6c629c8a7bcc5d&end=3984bc5833db8bfb0acc522c9775383e4171f3de&stat=instructions:u)
107+
108+
| (instructions:u) | mean | range | count |
109+
|:----------------------------------:|:-----:|:--------------:|:-----:|
110+
| Regressions ❌ <br /> (primary) | 0.6% | [0.5%, 0.6%] | 2 |
111+
| Regressions ❌ <br /> (secondary) | 1.2% | [1.2%, 1.2%] | 1 |
112+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.1%] | 52 |
113+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.5%, -0.2%] | 24 |
114+
| All ❌✅ (primary) | -0.2% | [-0.3%, 0.6%] | 54 |
115+
116+
* awesome amount of green (small but broad) in the per fresults
117+
118+
#### Mixed
119+
120+
Rollup of 10 pull requests [#106757](https://github.com/rust-lang/rust/pull/106757) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4887cb18dc2ef5b1bf3fc50ce6c267fde085032b&end=2b8590ef3bd1221830ec8a4131ea9d02b1636746&stat=instructions:u)
121+
122+
| (instructions:u) | mean | range | count |
123+
|:----------------------------------:|:-----:|:--------------:|:-----:|
124+
| Regressions ❌ <br /> (primary) | 0.6% | [0.6%, 0.7%] | 6 |
125+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
126+
| Improvements ✅ <br /> (primary) | - | - | 0 |
127+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.5%, -0.5%] | 1 |
128+
| All ❌✅ (primary) | 0.6% | [0.6%, 0.7%] | 6 |
129+
130+
* the regressing cases are all variation of diesel {full, incr-full}
131+
* Not marking #106757 as triaged. Doing some rust-timer runs on the individual builds.
132+
133+
Rollup of 10 pull requests [#106851](https://github.com/rust-lang/rust/pull/106851) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=44a500c8c187b245638684748f54bd6ec67e0b25&end=4b51adf6ffa1ae2286ea436eb48cbaa8771886e6&stat=instructions:u)
134+
135+
| (instructions:u) | mean | range | count |
136+
|:----------------------------------:|:-----:|:--------------:|:-----:|
137+
| Regressions ❌ <br /> (primary) | - | - | 0 |
138+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.5%] | 5 |
139+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.3%] | 4 |
140+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.6%, -0.1%] | 3 |
141+
| All ❌✅ (primary) | -0.4% | [-0.4%, -0.3%] | 4 |
142+
143+
* the regressing cases are secondary tuple-stress and deep-vector
144+
* left comment and marked as triaged.
145+
146+
Switch to `EarlyBinder` for `const_param_default` and `impl_trait_ref` queries [#106696](https://github.com/rust-lang/rust/pull/106696) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4b51adf6ffa1ae2286ea436eb48cbaa8771886e6&end=b8f9cb345ab1401f2fbd14cc23f64dda9dd2314e&stat=instructions:u)
147+
148+
| (instructions:u) | mean | range | count |
149+
|:----------------------------------:|:-----:|:--------------:|:-----:|
150+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
151+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
152+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 3 |
153+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
154+
| All ❌✅ (primary) | -0.2% | [-0.4%, 0.2%] | 4 |
155+
156+
* there is one small regression to bitmaps-full doc, and three improvements to bitmaps-incr-full {check, debug, opt}.
157+
* If its not noise, its seems like the right trade off.
158+
* left comment, marked as triaged.
159+
160+
#### Untriaged Pull Requests
161+
162+
- [#106853 Heuristically undo path prefix mappings.](https://github.com/rust-lang/rust/pull/106853)
163+
- [#106851 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/106851)
164+
- [#106822 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/106822)
165+
- [#106757 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/106757)
166+
- [#106730 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/106730)
167+
- [#106696 Switch to `EarlyBinder` for `const_param_default` and `impl_trait_ref` queries](https://github.com/rust-lang/rust/pull/106696)
168+
- [#105657 Guard ProjectionTy creation against passing the wrong number of substs](https://github.com/rust-lang/rust/pull/105657)
169+
- [#105472 Make encode_info_for_trait_item use queries instead of accessing the HIR](https://github.com/rust-lang/rust/pull/105472)
170+
- [#105426 Catch panics/unwinding in destruction of TLS values](https://github.com/rust-lang/rust/pull/105426)
171+
- [#105378 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/105378)
172+
- [#105323 Perform SimplifyLocals before ConstProp.](https://github.com/rust-lang/rust/pull/105323)
173+
- [#105147 Allow unsafe through inline const](https://github.com/rust-lang/rust/pull/105147)
174+
- [#104566 couple of clippy::perf fixes](https://github.com/rust-lang/rust/pull/104566)
175+
- [#104533 Clean up and harden various methods around trait substs](https://github.com/rust-lang/rust/pull/104533)
176+
- [#104017 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/104017)
177+
- [#103998 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/103998)
178+
- [#103975 Some tracing and comment cleanups](https://github.com/rust-lang/rust/pull/103975)
179+
- [#103934 std: sync "Dependencies of the `backtrace` crate" with `backtrace`](https://github.com/rust-lang/rust/pull/103934)
180+
- [#103880 Use non-ascribed type as field's type in mir](https://github.com/rust-lang/rust/pull/103880)
181+
- [#103841 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/103841)
182+
- [#103650 rustdoc: change `.src-line-numbers > span` to `.src-line-numbers > a`](https://github.com/rust-lang/rust/pull/103650)
183+
- [#103562 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/103562)
184+
- [#103439 Show note where the macro failed to match](https://github.com/rust-lang/rust/pull/103439)
185+
- [#103295 ci: Bring back ninja for dist builders](https://github.com/rust-lang/rust/pull/103295)
186+
- [#103071 Fix line numbers for MIR inlined code](https://github.com/rust-lang/rust/pull/103071)
187+
- [#102975 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/102975)
188+
- [#102915 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/102915)
189+
- [#102895 Get rid of `rustc_query_description!`](https://github.com/rust-lang/rust/pull/102895)
190+
- [#102867 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/102867)
191+
- [#102809 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/102809)

0 commit comments

Comments
 (0)