Skip to content

Commit 7965c10

Browse files
authored
Merge pull request #1950 from Mark-Simulacrum/triage
Triage for this week
2 parents 0dd5af8 + e9099d5 commit 7965c10

File tree

1 file changed

+63
-0
lines changed

1 file changed

+63
-0
lines changed

triage/2024-07-21.md

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
# 2024-07-21 Triage Log
2+
3+
Light week, with few changes on any dimension (including memory), though
4+
overall a slight regression.
5+
6+
Triage done by **@simulacrum**.
7+
Revision range: [5572759b..9629b90b](https://perf.rust-lang.org/?start=5572759b8d7012fa34eba47f4885c76fa06d9251&end=9629b90b3f7dd8f5626ec9d3b42556f39f09e214&absolute=false&stat=instructions%3Au)
8+
9+
**Summary**:
10+
11+
| (instructions:u) | mean | range | count |
12+
|:----------------------------------:|:-----:|:--------------:|:-----:|
13+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.8%] | 6 |
14+
| Regressions ❌ <br /> (secondary) | 1.3% | [0.2%, 7.3%] | 13 |
15+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.9%, -0.5%] | 6 |
16+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
17+
| All ❌✅ (primary) | -0.1% | [-0.9%, 0.8%] | 12 |
18+
19+
1 Regression, 1 Improvement, 1 Mixed; 2 of them in rollups
20+
34 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 8 pull requests [#127865](https://github.com/rust-lang/rust/pull/127865) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fcc325f1bc477975e2ce5ba534fe4c77ff8a8536&end=e35364a521372ce682e4bd4a5850d97ea33b0eab&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.6% | [0.4%, 0.7%] | 4 |
29+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.6%, 2.1%] | 7 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.6% | [0.4%, 0.7%] | 4 |
33+
34+
Clear regression, though contributing PR from the rollup is not clear. Started
35+
a build to try to dig deeper.
36+
37+
#### Improvements
38+
39+
Represent type-level consts with new-and-improved `hir::ConstArg` [#125915](https://github.com/rust-lang/rust/pull/125915) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3d68afc9e821b00d59058abc9bda670b07639955&end=8c3a94a1c79c67924558a4adf7fb6d98f5f0f741&stat=instructions:u)
40+
41+
| (instructions:u) | mean | range | count |
42+
|:----------------------------------:|:-----:|:--------------:|:-----:|
43+
| Regressions ❌ <br /> (primary) | - | - | 0 |
44+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
45+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.8%, -0.5%] | 6 |
46+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
47+
| All ❌✅ (primary) | -0.6% | [-0.8%, -0.5%] | 6 |
48+
49+
50+
#### Mixed
51+
52+
Rollup of 9 pull requests [#127998](https://github.com/rust-lang/rust/pull/127998) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=41ff4608894d260462a7b6cf1ddefc6c8ecf6b1c&end=1afc5fd042f7583b9668dd62be98325487483d1c&stat=instructions:u)
53+
54+
| (instructions:u) | mean | range | count |
55+
|:----------------------------------:|:-----:|:--------------:|:-----:|
56+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 2 |
57+
| Regressions ❌ <br /> (secondary) | 1.3% | [1.3%, 1.3%] | 1 |
58+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.7%] | 1 |
59+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
60+
| All ❌✅ (primary) | -0.1% | [-0.7%, 0.3%] | 3 |
61+
62+
Clear regression, though contributing PR from the rollup is not clear. Started
63+
a build to try to dig deeper.

0 commit comments

Comments
 (0)