Skip to content

Commit af1e9af

Browse files
rylevrylev
authored
Merge pull request #1976 from rylev/perf-triage-2024-09-10
Add perf triage for 2024-09-10
2 parents e76c90f + fe90cb3 commit af1e9af

File tree

1 file changed

+97
-0
lines changed

1 file changed

+97
-0
lines changed

‎triage/2024-09-10.md

+97
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,97 @@
1+
# 2024-09-10 Triage Log
2+
3+
A relatively quiet week with a majority of regressions coming in rollups which makes investigation more difficult. Luckily the regressions are relatively small and overall the week was a slight improvement in compiler performance.
4+
5+
Triage done by **@rylev**.
6+
Revision range: [6199b69c..263a3aee](https://perf.rust-lang.org/?start=6199b69c53a8c275ca3cd59647ea0af5ca29aae2&end=263a3aeeb8f2d0e9cc85eee61774d1f5f23dc3f5&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.4%] | 57 |
13+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.2%, 1.5%] | 23 |
14+
| Improvements ✅ <br /> (primary) | -2.2% | [-4.0%, -0.4%] | 23 |
15+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.2%] | 10 |
16+
| All ❌✅ (primary) | -0.2% | [-4.0%, 1.4%] | 80 |
17+
18+
19+
3 Regressions, 1 Improvement, 2 Mixed; 3 of them in rollups
20+
26 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 8 pull requests [#129922](https://github.com/rust-lang/rust/pull/129922) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6199b69c53a8c275ca3cd59647ea0af5ca29aae2&end=d6c8169c186ab16a3404cd0d0866674018e8a19e&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | - | - | 0 |
29+
| Regressions ❌ <br /> (secondary) | 5.8% | [5.8%, 5.8%] | 1 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | - | - | 0 |
33+
- Noise
34+
35+
36+
Update x86_64-linux host compiler to LLVM 19 rc 3 [#129356](https://github.com/rust-lang/rust/pull/129356) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d6c8169c186ab16a3404cd0d0866674018e8a19e&end=842d6fc32e3d0d26bb11fbe6a2f6ae2afccc06cb&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:-----:|:--------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 0.8%] | 34 |
41+
| Regressions ❌ <br /> (secondary) | 2.6% | [0.5%, 5.7%] | 6 |
42+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
43+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
44+
| All ❌✅ (primary) | 0.5% | [-0.4%, 0.8%] | 35 |
45+
- "Looks like this update is a very mild regression, but not enough to look into it in more detail, or skip this version."
46+
47+
48+
Rollup of 10 pull requests [#130091](https://github.com/rust-lang/rust/pull/130091) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=12b26c13fba25c9e1bc2fdf05f3c2dbb851c83de&end=878f49f5ff0dd88a85bcd5d99fc0d90e219c354c&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:----:|:------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | 0.9% | [0.3%, 1.7%] | 13 |
53+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 1.3%] | 14 |
54+
| Improvements ✅ <br /> (primary) | - | - | 0 |
55+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
56+
| All ❌✅ (primary) | 0.9% | [0.3%, 1.7%] | 13 |
57+
- Regressions are happening in `expand_crate` so testing a change that touched `rustc_expand`
58+
59+
60+
#### Improvements
61+
62+
Use `DeepRejectCtxt` to quickly reject `ParamEnv` candidates [#128776](https://github.com/rust-lang/rust/pull/128776) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=17b322fa69eed7216dccc9f097eb68237cf62234&end=26b5599e4d6ed2b45152c60493c1788c0a27533d&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
68+
| Improvements ✅ <br /> (primary) | -1.8% | [-4.7%, -0.3%] | 17 |
69+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
70+
| All ❌✅ (primary) | -1.8% | [-4.7%, -0.3%] | 17 |
71+
72+
73+
#### Mixed
74+
75+
Rollup of 10 pull requests [#129978](https://github.com/rust-lang/rust/pull/129978) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=009e73825af0e59ad4fc603562e038b3dbd6593a&end=eb33b43bab08223fa6b46abacc1e95e859fe375d&stat=instructions:u)
76+
77+
| (instructions:u) | mean | range | count |
78+
|:----------------------------------:|:-----:|:--------------:|:-----:|
79+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.5%] | 4 |
80+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 1 |
81+
| Improvements ✅ <br /> (primary) | - | - | 0 |
82+
| Improvements ✅ <br /> (secondary) | -3.1% | [-3.1%, -3.1%] | 1 |
83+
| All ❌✅ (primary) | 0.4% | [0.3%, 0.5%] | 4 |
84+
- The regressions here are small enough that I don't think it's worth investigating further.
85+
86+
87+
stabilize `-Znext-solver=coherence` [#121848](https://github.com/rust-lang/rust/pull/121848) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=59d4114b2d1aaac9a6dfe770997f2e79ccfd28ab&end=17b322fa69eed7216dccc9f097eb68237cf62234&stat=instructions:u)
88+
89+
| (instructions:u) | mean | range | count |
90+
|:----------------------------------:|:-----:|:--------------:|:-----:|
91+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.6%] | 11 |
92+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.4%, 5.1%] | 8 |
93+
| Improvements ✅ <br /> (primary) | -3.4% | [-4.2%, -2.8%] | 7 |
94+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.2%] | 5 |
95+
| All ❌✅ (primary) | -1.1% | [-4.2%, 0.6%] | 18 |
96+
- Mainly noise
97+

0 commit comments

Comments
 (0)