Skip to content

Commit d303f2e

Browse files
Merge pull request #882 from klensy/fix-empty-query
escape query name to prevent rendering it as html
2 parents 59ec9ca + 6da9fb8 commit d303f2e

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

site/static/detailed-query.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,8 @@ <h3 id="title"></h3>
273273
function to_object(element) {
274274
if (!element.length) {
275275
element = [
276-
element.label,
276+
// escape html, to prevent rendering queries like <unknown> as tags
277+
escapeHtml(element.label),
277278
[ element.self_time.secs, element.self_time.nanos ],
278279
element.percent_total_time,
279280
element.number_of_cache_misses,

site/static/shared.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,3 +252,13 @@ function make_request(path, body) {
252252
console.log("error fetching ", path, ": ", err);
253253
});
254254
}
255+
256+
// https://stackoverflow.com/questions/6234773
257+
function escapeHtml(unsafe) {
258+
return unsafe
259+
.replace(/&/g, "&amp;")
260+
.replace(/</g, "&lt;")
261+
.replace(/>/g, "&gt;")
262+
.replace(/"/g, "&quot;")
263+
.replace(/'/g, "&#039;");
264+
}

0 commit comments

Comments
 (0)