Skip to content

Commit fa216f5

Browse files
pnkfelixpnkfelix
authored
Merge pull request #1507 from Mark-Simulacrum/triage
Add triage for this week
2 parents 2322d58 + d657ad7 commit fa216f5

File tree

1 file changed

+127
-0
lines changed

1 file changed

+127
-0
lines changed

‎triage/2022-12-20.md

Lines changed: 127 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
1+
# 2022-12-20 Triage Log
2+
3+
Relatively quiet week for performance, with most regressions and improvements being pretty small.
4+
5+
Triage done by **@simulacrum**.
6+
Revision range: [109cccbe4f345c0f0785ce860788580c3e2a29f5..8a746f4ac3a489efb724cde813607f3b96c2df7b](https://perf.rust-lang.org/?start=109cccbe4f345c0f0785ce860788580c3e2a29f5&end=8a746f4ac3a489efb724cde813607f3b96c2df7b&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.9% | [0.2%, 2.8%] | 28 |
13+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.2%, 1.3%] | 39 |
14+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.1%, -1.0%] | 2 |
15+
| Improvements ✅ <br /> (secondary) | -1.7% | [-4.3%, -0.2%] | 24 |
16+
| All ❌✅ (primary) | 0.8% | [-1.1%, 2.8%] | 30 |
17+
18+
19+
3 Regressions, 4 Improvements, 2 Mixed; 3 of them in rollups
20+
53 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
use ty::Binder in rustdoc instead of `skip_binder` [#105612](https://github.com/rust-lang/rust/pull/105612) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=109cccbe4f345c0f0785ce860788580c3e2a29f5&end=ed620cf9690fdafed65845bf35c455db992fbba1&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.5%] | 5 |
29+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 0.7%] | 9 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.5%] | 5 |
33+
34+
> The regressions are expected, solely in rustdoc and part of a bugfix.
35+
36+
Use non-ascribed type as field's type in mir [#103880](https://github.com/rust-lang/rust/pull/103880) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=01ef4b21dc5251b58bd9c6fd6face2ae95d56da1&end=03770f0e2b60c02db8fcf52fed5fb36aac70cedc&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:----:|:------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | - | - | 0 |
41+
| Regressions ❌ <br /> (secondary) | 3.1% | [2.5%, 3.7%] | 2 |
42+
| Improvements ✅ <br /> (primary) | - | - | 0 |
43+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
44+
| All ❌✅ (primary) | - | - | 0 |
45+
46+
Regression does not appear to be noise, however the PR in question has been reverted (due to non-perf regressions).
47+
48+
Add `IMPLIED_BOUNDS_ENTAILMENT` lint [#105575](https://github.com/rust-lang/rust/pull/105575) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c43bc135628bc0d472e1a1259d56b72b7de0a274&end=7f42e58effa3871dda6a41e250dea60cf88868ca&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:----:|:------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | 0.9% | [0.2%, 2.3%] | 20 |
53+
| Regressions ❌ <br /> (secondary) | 1.6% | [0.6%, 2.6%] | 12 |
54+
| Improvements ✅ <br /> (primary) | - | - | 0 |
55+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
56+
| All ❌✅ (primary) | 0.9% | [0.2%, 2.3%] | 20 |
57+
58+
New lint for a soundness fix. Regressions relatively limited regardless.
59+
60+
#### Improvements
61+
62+
Revert "enable ThinLTO for rustc on x86_64-apple-darwin dist builds" [#105646](https://github.com/rust-lang/rust/pull/105646) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ed620cf9690fdafed65845bf35c455db992fbba1&end=aa5b179599427ef233c4e47db8dac6edae22b4f8&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
68+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
69+
| Improvements ✅ <br /> (secondary) | -2.0% | [-2.6%, -0.8%] | 7 |
70+
| All ❌✅ (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
71+
72+
73+
Rollup of 5 pull requests [#105892](https://github.com/rust-lang/rust/pull/105892) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=10723378900ba2d25fc5d8baf785e1082f385832&end=4653c93e4442d88bf3278067183c8fdc0be74a1f&stat=instructions:u)
74+
75+
| (instructions:u) | mean | range | count |
76+
|:----------------------------------:|:-----:|:--------------:|:-----:|
77+
| Regressions ❌ <br /> (primary) | - | - | 0 |
78+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
79+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
80+
| Improvements ✅ <br /> (secondary) | -2.2% | [-2.6%, -2.0%] | 6 |
81+
| All ❌✅ (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
82+
83+
84+
Revert #103880 "Use non-ascribed type as field's type in mir" [#105905](https://github.com/rust-lang/rust/pull/105905) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=935dc07218b4bf6e20231e44eb9263b612fd649b&end=696563efc5c3c0d87a601dff22966d2c5eb20a5e&stat=instructions:u)
85+
86+
| (instructions:u) | mean | range | count |
87+
|:----------------------------------:|:-----:|:--------------:|:-----:|
88+
| Regressions ❌ <br /> (primary) | - | - | 0 |
89+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
90+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.3%, -0.3%] | 5 |
91+
| Improvements ✅ <br /> (secondary) | -1.7% | [-3.5%, -0.4%] | 14 |
92+
| All ❌✅ (primary) | -0.7% | [-1.3%, -0.3%] | 5 |
93+
94+
95+
Rollup of 5 pull requests [#105940](https://github.com/rust-lang/rust/pull/105940) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eb9e5e711d3eef1998ff24ac2bc57386662652e9&end=8a746f4ac3a489efb724cde813607f3b96c2df7b&stat=instructions:u)
96+
97+
| (instructions:u) | mean | range | count |
98+
|:----------------------------------:|:-----:|:--------------:|:-----:|
99+
| Regressions ❌ <br /> (primary) | - | - | 0 |
100+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
101+
| Improvements ✅ <br /> (primary) | -1.1% | [-1.1%, -1.0%] | 2 |
102+
| Improvements ✅ <br /> (secondary) | -1.7% | [-2.6%, -0.4%] | 9 |
103+
| All ❌✅ (primary) | -1.1% | [-1.1%, -1.0%] | 2 |
104+
105+
106+
#### Mixed
107+
108+
Guard ProjectionTy creation against passing the wrong number of substs [#105657](https://github.com/rust-lang/rust/pull/105657) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=939a3ddf943f962807b84a44e8b31d99c0db0a94&end=a8847df167c5851caf8f465354fc3d73b7e9338c&stat=instructions:u)
109+
110+
| (instructions:u) | mean | range | count |
111+
|:----------------------------------:|:-----:|:--------------:|:-----:|
112+
| Regressions ❌ <br /> (primary) | - | - | 0 |
113+
| Regressions ❌ <br /> (secondary) | 1.0% | [0.7%, 1.2%] | 9 |
114+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.1%] | 2 |
115+
| Improvements ✅ <br /> (secondary) | -0.7% | [-0.7%, -0.5%] | 8 |
116+
| All ❌✅ (primary) | -0.4% | [-0.6%, -0.1%] | 2 |
117+
118+
119+
Rollup of 7 pull requests [#105918](https://github.com/rust-lang/rust/pull/105918) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=696563efc5c3c0d87a601dff22966d2c5eb20a5e&end=c43bc135628bc0d472e1a1259d56b72b7de0a274&stat=instructions:u)
120+
121+
| (instructions:u) | mean | range | count |
122+
|:----------------------------------:|:-----:|:--------------:|:-----:|
123+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
124+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
125+
| Improvements ✅ <br /> (primary) | - | - | 0 |
126+
| Improvements ✅ <br /> (secondary) | -2.1% | [-4.4%, -0.8%] | 12 |
127+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.2%] | 1 |

0 commit comments

Comments
 (0)