Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

Commit 8f44658

Browse files
committed
Adjust wording when asking for bug report
This omits the reference to gist (which may confuse people not familiar with gist.github.com), and moves the link to our issue tracker to its own line, which makes copying easier (for those whose terminals don't have a "ctrl+click to open link" feature).
1 parent 59b3617 commit 8f44658

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

cargo-fix/src/cli.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,15 @@ use lock;
1010
use diagnostics::{Message, Server};
1111
use super::exit_with;
1212

13+
static PLEASE_REPORT_THIS_BUG: &str = "\
14+
This likely indicates a bug in either rustc or rustfix itself,\n\
15+
and we would appreciate a bug report! You're likely to see \n\
16+
a number of compiler warnings after this message which rustfix\n\
17+
attempted to fix but failed. If you could open an issue at\n\
18+
https://github.com/rust-lang-nursery/rustfix/issues\n\
19+
quoting the full output of this command we'd be very appreciative!\n\n\
20+
";
21+
1322
pub fn run() -> Result<(), Error> {
1423
let matches = App::new("Cargo Fix")
1524
.bin_name("cargo")
@@ -121,16 +130,7 @@ fn log_message(msg: &Message, stream: &mut StandardStream) -> Result<(), Error>
121130
write!(stream, "\n")?;
122131

123132
}
124-
write!(
125-
stream,
126-
"This likely indicates a bug in either rustc or rustfix itself,\n\
127-
and we would appreciate a bug report! You're likely to see \n\
128-
a number of compiler warnings after this message which rustfix\n\
129-
attempted to fix but failed. If you could gist the full output\n\
130-
of this command to https://github.com/rust-lang-nursery/rustfix/issues\n\
131-
we'd be very appreciative!\n\n\
132-
"
133-
)?;
133+
stream.write(PLEASE_REPORT_THIS_BUG.as_bytes())?;
134134
}
135135
}
136136

cargo-fix/tests/all/broken_build.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,9 @@ fn broken_fixes_backed_out() {
127127
This likely indicates a bug in either rustc or rustfix itself,\n\
128128
and we would appreciate a bug report! You're likely to see \n\
129129
a number of compiler warnings after this message which rustfix\n\
130-
attempted to fix but failed. If you could gist the full output\n\
131-
of this command to https://github.com/rust-lang-nursery/rustfix/issues\n\
132-
we'd be very appreciative!\
130+
attempted to fix but failed. If you could open an issue at\n\
131+
https://github.com/rust-lang-nursery/rustfix/issues\n\
132+
quoting the full output of this command we'd be very appreciative!\n\n\
133133
"
134134
)
135135
.stderr_not_contains("[FIXING]")

0 commit comments

Comments
 (0)