Move Socket::set_no_peercred to src/sys/unix.rs

It's Cygwin (Unix) only.

Author: Thomasdezeeuw

src/socket.rs

@@ -992,30 +992,6 @@ impl Socket {
         }
     }
 
-    /// Sets `SO_PEERCRED` to null on the socket.
-    ///
-    /// This is a Cygwin extension.
-    ///
-    /// Normally the Unix domain sockets of Cygwin are implemented by TCP sockets,
-    /// so it performs a handshake on `connect` and `accept` to verify the remote
-    /// connection and exchange peer cred info. At the time of writing, this
-    /// means that `connect` on a Unix domain socket will block until the server
-    /// calls `accept` on Cygwin. This behavior is inconsistent with most other
-    /// platforms, and this option can be used to disable that.
-    ///
-    /// See also: the [mailing list](https://inbox.sourceware.org/cygwin/TYCPR01MB10926FF8926CA63704867ADC8F8AA2@TYCPR01MB10926.jpnprd01.prod.outlook.com/)
-    #[cfg(any(doc, target_os = "cygwin"))]
-    pub fn set_no_peercred(&self) -> io::Result<()> {
-        #[cfg(target_os = "cygwin")]
-        {
-            self._set_no_peercred()
-        }
-        #[cfg(not(target_os = "cygwin"))]
-        {
-            unimplemented!()
-        }
-    }
-
     /// Get value for the `SO_RCVBUF` option on this socket.
     ///
     /// For more information about this option, see [`set_recv_buffer_size`].

src/sys/unix.rs

@@ -282,8 +282,6 @@ pub(crate) use libc::{TCP_KEEPCNT, TCP_KEEPINTVL};
 // See this type in the Windows file.
 pub(crate) type Bool = c_int;
 
-#[cfg(target_os = "cygwin")]
-use libc::SO_PEERCRED;
 #[cfg(any(
     target_os = "ios",
     target_os = "visionos",
@@ -1501,12 +1499,25 @@ impl crate::Socket {
         }
     }
 
+    /// Sets `SO_PEERCRED` to null on the socket.
+    ///
+    /// This is a Cygwin extension.
+    ///
+    /// Normally the Unix domain sockets of Cygwin are implemented by TCP sockets,
+    /// so it performs a handshake on `connect` and `accept` to verify the remote
+    /// connection and exchange peer cred info. At the time of writing, this
+    /// means that `connect` on a Unix domain socket will block until the server
+    /// calls `accept` on Cygwin. This behavior is inconsistent with most other
+    /// platforms, and this option can be used to disable that.
+    ///
+    /// See also: the [mailing list](https://inbox.sourceware.org/cygwin/TYCPR01MB10926FF8926CA63704867ADC8F8AA2@TYCPR01MB10926.jpnprd01.prod.outlook.com/)
     #[cfg(target_os = "cygwin")]
-    pub(crate) fn _set_no_peercred(&self) -> io::Result<()> {
+    #[cfg(any(doc, target_os = "cygwin"))]
+    pub fn set_no_peercred(&self) -> io::Result<()> {
         syscall!(setsockopt(
             self.as_raw(),
-            SOL_SOCKET,
-            SO_PEERCRED,
+            libc::SOL_SOCKET,
+            libc::SO_PEERCRED,
             ptr::null_mut(),
             0,
         ))