fixup

Author: gnzlbg

coresimd/ppsv/api/minmax_reductions.rs

@@ -5,21 +5,60 @@ macro_rules! impl_minmax_reductions {
     ($id:ident, $elem_ty:ident) => {
         impl $id {
             /// Largest vector value.
+            ///
+            /// FIXME: document behavior for float vectors with NaNs.
+            #[cfg(not(target_arch = "aarch64"))]
             #[inline]
             pub fn max(self) -> $elem_ty {
                 use ::coresimd::simd_llvm::simd_reduce_max;
                 unsafe {
                     simd_reduce_max(self)
                 }
             }
+            /// Largest vector value.
+            ///
+            /// FIXME: document behavior for float vectors with NaNs.
+            #[cfg(target_arch = "aarch64")]
+            #[allow(unused_imports)]
+            #[inline]
+            pub fn max(self) -> $elem_ty {
+                // FIXME: broken on AArch64
+                use ::num::Float;
+                use ::cmp::Ord;
+                let mut x = self.extract(0);
+                for i in 1..$id::lanes() {
+                    x = x.max(self.extract(i));
+                }
+                x
+            }
+
             /// Smallest vector value.
+            ///
+            /// FIXME: document behavior for float vectors with NaNs.
+            #[cfg(not(target_arch = "aarch64"))]
             #[inline]
             pub fn min(self) -> $elem_ty {
                 use ::coresimd::simd_llvm::simd_reduce_min;
                 unsafe {
                     simd_reduce_min(self)
                 }
             }
+            /// Smallest vector value.
+            ///
+            /// FIXME: document behavior for float vectors with NaNs.
+            #[cfg(target_arch = "aarch64")]
+            #[allow(unused_imports)]
+            #[inline]
+            pub fn min(self) -> $elem_ty {
+                // FIXME: broken on AArch64
+                use ::num::Float;
+                use ::cmp::Ord;
+                let mut x = self.extract(0);
+                for i in 1..$id::lanes() {
+                    x = x.min(self.extract(i));
+                }
+                x
+            }
         }
     }
 }