Skip to content

Commit c283960

Browse files
committed
Change feature detection names
1 parent 8f3ebb8 commit c283960

File tree

5 files changed

+21
-9
lines changed

5 files changed

+21
-9
lines changed

crates/core_arch/tests/cpu-detection.rs

+3
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,11 @@ fn x86_all() {
3131
is_x86_feature_detected!("avx512vpopcntdq")
3232
);
3333
println!("avx512vbmi2 {:?}", is_x86_feature_detected!("avx512vbmi2"));
34+
println!("gfni {:?}", is_x86_feature_detected!("gfni"));
3435
println!("avx512gfni {:?}", is_x86_feature_detected!("avx512gfni"));
36+
println!("vaes {:?}", is_x86_feature_detected!("vaes"));
3537
println!("avx512vaes {:?}", is_x86_feature_detected!("avx512vaes"));
38+
println!("vpclmulqdq {:?}", is_x86_feature_detected!("vpclmulqdq"));
3639
println!(
3740
"avx512vpclmulqdq {:?}",
3841
is_x86_feature_detected!("avx512vpclmulqdq")

crates/std_detect/src/detect/arch/x86.rs

+9-6
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ features! {
6868
/// * `"avx512vbmi"`
6969
/// * `"avx512vpopcntdq"`
7070
/// * `"avx512vbmi2"`
71-
/// * `"avx512gfni"`
72-
/// * `"avx512vaes"`
73-
/// * `"avx512vpclmulqdq"`
71+
/// * `"gfni"`
72+
/// * `"vaes"`
73+
/// * `"vpclmulqdq"`
7474
/// * `"avx512vnni"`
7575
/// * `"avx512bitalg"`
7676
/// * `"avx512bf16"`
@@ -95,6 +95,9 @@ features! {
9595
/// [docs]: https://software.intel.com/sites/landingpage/IntrinsicsGuide
9696
#[stable(feature = "simd_x86", since = "1.27.0")]
9797
@BIND_FEATURE_NAME: "abm"; "lzcnt"; // abm is a synonym for lzcnt
98+
@BIND_FEATURE_NAME: "avx512gfni"; "gfni"; // avx512gfni was previously used for gnfi
99+
@BIND_FEATURE_NAME: "avx512vaes"; "vaes"; // avx512vaes was previously used for vaes
100+
@BIND_FEATURE_NAME: "avx512vpclmulqdq"; "vpclmulqdq"; // avx512vpclmulqdq was previously used for vpclmulqdq
98101
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] aes: "aes";
99102
/// AES (Advanced Encryption Standard New Instructions AES-NI)
100103
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] pclmulqdq: "pclmulqdq";
@@ -150,11 +153,11 @@ features! {
150153
/// Quadword)
151154
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512vbmi2: "avx512vbmi2";
152155
/// AVX-512 VBMI2 (Additional byte, word, dword and qword capabilities)
153-
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512gfni: "avx512gfni";
156+
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] gfni: "gfni";
154157
/// AVX-512 GFNI (Galois Field New Instruction)
155-
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512vaes: "avx512vaes";
158+
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] vaes: "vaes";
156159
/// AVX-512 VAES (Vector AES instruction)
157-
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512vpclmulqdq: "avx512vpclmulqdq";
160+
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] vpclmulqdq: "vpclmulqdq";
158161
/// AVX-512 VPCLMULQDQ (Vector PCLMULQDQ instructions)
159162
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512vnni: "avx512vnni";
160163
/// AVX-512 VNNI (Vector Neural Network Instructions)

crates/std_detect/src/detect/os/x86.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,10 @@ pub(crate) fn detect_features() -> cache::Initializer {
211211
enable(extended_features_ecx, 1, Feature::avx512vbmi);
212212
enable(extended_features_ecx, 5, Feature::avx512bf16);
213213
enable(extended_features_ecx, 6, Feature::avx512vbmi2);
214-
enable(extended_features_ecx, 8, Feature::avx512gfni);
214+
enable(extended_features_ecx, 8, Feature::gfni);
215215
enable(extended_features_ecx, 8, Feature::avx512vp2intersect);
216-
enable(extended_features_ecx, 9, Feature::avx512vaes);
217-
enable(extended_features_ecx, 10, Feature::avx512vpclmulqdq);
216+
enable(extended_features_ecx, 9, Feature::vaes);
217+
enable(extended_features_ecx, 10, Feature::vpclmulqdq);
218218
enable(extended_features_ecx, 11, Feature::avx512vnni);
219219
enable(extended_features_ecx, 12, Feature::avx512bitalg);
220220
enable(extended_features_ecx, 14, Feature::avx512vpopcntdq);

crates/std_detect/tests/cpu-detection.rs

+3
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,11 @@ fn x86_all() {
132132
is_x86_feature_detected!("avx512vpopcntdq")
133133
);
134134
println!("avx512vbmi2 {:?}", is_x86_feature_detected!("avx512vbmi2"));
135+
println!("gfni {:?}", is_x86_feature_detected!("gfni"));
135136
println!("avx512gfni {:?}", is_x86_feature_detected!("avx512gfni"));
137+
println!("vaes {:?}", is_x86_feature_detected!("vaes"));
136138
println!("avx512vaes {:?}", is_x86_feature_detected!("avx512vaes"));
139+
println!("vpclmulqdq {:?}", is_x86_feature_detected!("vpclmulqdq"));
137140
println!(
138141
"avx512vpclmulqdq {:?}",
139142
is_x86_feature_detected!("avx512vpclmulqdq")

crates/std_detect/tests/x86-specific.rs

+3
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,11 @@ fn dump() {
3636
is_x86_feature_detected!("avx512vpopcntdq")
3737
);
3838
println!("avx512vbmi2 {:?}", is_x86_feature_detected!("avx512vbmi2"));
39+
println!("gfni {:?}", is_x86_feature_detected!("gfni"));
3940
println!("avx512gfni {:?}", is_x86_feature_detected!("avx512gfni"));
41+
println!("vaes {:?}", is_x86_feature_detected!("vaes"));
4042
println!("avx512vaes {:?}", is_x86_feature_detected!("avx512vaes"));
43+
println!("vpclmulqdq {:?}", is_x86_feature_detected!("vpclmulqdq"));
4144
println!(
4245
"avx512vpclmulqdq {:?}",
4346
is_x86_feature_detected!("avx512vpclmulqdq")

0 commit comments

Comments
 (0)