These items do not need to be public

Author: gnzlbg

crates/std_detect/src/detect/macros.rs

@@ -52,7 +52,7 @@ macro_rules! features {
         #[derive(Copy, Clone)]
         #[repr(u8)]
         #[unstable(feature = "stdsimd_internal", issue = "0")]
-        pub enum Feature {
+        pub(crate) enum Feature {
             $(
                 $(#[$feature_comment])*
                 $feature,
@@ -63,13 +63,13 @@ macro_rules! features {
         }
 
         impl Feature {
-            pub fn to_str(self) -> &'static str {
+            pub(crate) fn to_str(self) -> &'static str {
                 match self {
                     $(Feature::$feature => $feature_lit,)*
                     Feature::_last => unreachable!(),
                 }
             }
-            pub fn from_str(s: &str) -> Result<Feature, ()> {
+            pub(crate) fn from_str(s: &str) -> Result<Feature, ()> {
                 match s {
                     $($feature_lit => Ok(Feature::$feature),)*
                     _ => Err(())
@@ -89,6 +89,7 @@ macro_rules! features {
 
                 /// PLEASE: do not use this, it is an implementation detail
                 /// subject to change.
+                #[inline]
                 #[doc(hidden)]
                 #[$stability_attr]
                 pub fn $feature() -> bool {

crates/std_detect/src/detect/mod.rs

@@ -56,22 +56,28 @@ cfg_if! {
         // Unimplemented architecture:
         mod arch {
             #[doc(hidden)]
-            pub enum Feature {
+            pub(crate) enum Feature {
                 Null
             }
             #[doc(hidden)]
             pub mod __is_feature_detected {}
 
             impl Feature {
                 #[doc(hidden)]
-                pub fn from_str(_s: &str) -> Result<Feature, ()> { Err(()) }
+                pub(crate) fn from_str(_s: &str) -> Result<Feature, ()> { Err(()) }
                 #[doc(hidden)]
-                pub fn to_str(self) -> &'static str { "" }
+                pub(crate) fn to_str(self) -> &'static str { "" }
             }
         }
     }
 }
-pub use self::arch::{Feature, __is_feature_detected};
+
+// This module needs to be public because the `is_{arch}_feature_detected!`
+// macros expand calls to items within it in user crates.
+#[doc(hidden)]
+pub use self::arch::__is_feature_detected;
+
+pub(crate) use self::arch::Feature;
 
 mod bit;
 mod cache;
@@ -106,7 +112,7 @@ cfg_if! {
 
 /// Performs run-time feature detection.
 #[inline]
-pub fn check_for(x: Feature) -> bool {
+fn check_for(x: Feature) -> bool {
     cache::test(x as u32, self::os::detect_features)
 }