Skip to content

Commit 43cb2b1

Browse files
committed
ci: organize nightly CI jobs
"Build (nightly + unstable feature)" was misleading, as it also ran unit tests, doc tests, builds everything, and runs miri. I decoupled plus renamed things for a better separation of concerns.
1 parent 0358496 commit 43cb2b1

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

.github/workflows/rust.yml

+16-1
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,9 @@ jobs:
136136
- uses: Swatinem/rust-cache@v2
137137
- name: Build
138138
run: cargo xtask build --feature-permutations
139+
# Nightly + unstable feature
139140
nightly_channel:
140-
name: Build (nightly + unstable feature)
141+
name: Nightly (build, test, doc)
141142
runs-on: ubuntu-latest
142143
env:
143144
# TODO: temporarily allow warnings to not be errors on nightly due to
@@ -163,6 +164,20 @@ jobs:
163164
# Skip testing uefi-macros on nightly because the tests that check the
164165
# compiler error output produce different output on stable vs nightly.
165166
run: cargo xtask test --unstable --skip-macro-tests
167+
miri:
168+
name: Unit + Doc Tests (Miri)
169+
runs-on: ubuntu-latest
170+
env:
171+
# TODO: temporarily allow warnings to not be errors on nightly due to
172+
# incorrect dead_code lint.
173+
# https://github.com/rust-osdev/uefi-rs/issues/1205
174+
RUSTFLAGS: ""
175+
steps:
176+
- name: Checkout sources
177+
uses: actions/checkout@v4
178+
- name: Enable nightly toolchain
179+
run: cp .github/workflows/nightly_toolchain.toml rust-toolchain.toml
180+
- uses: Swatinem/rust-cache@v2
166181
- name: Run unit tests and doctests under Miri
167182
run: |
168183
rustup component add miri

0 commit comments

Comments
 (0)