clippy: add const to more fns

Author: phip1611

uefi/src/mem/aligned_buffer.rs

@@ -47,7 +47,7 @@ impl AlignedBuffer {
 
     /// Get a mutable pointer to the aligned memory region managed by this instance.
     #[must_use]
-    pub fn ptr_mut(&mut self) -> *mut u8 {
+    pub const fn ptr_mut(&mut self) -> *mut u8 {
         self.ptr.as_ptr()
     }
 

uefi/src/mem/memory_map/impl_.rs

@@ -335,7 +335,7 @@ impl MemoryMapBackingMemory {
 
     /// Returns a mutable slice to the underlying memory.
     #[must_use]
-    pub fn as_mut_slice(&mut self) -> &mut [u8] {
+    pub const fn as_mut_slice(&mut self) -> &mut [u8] {
         unsafe { self.0.as_mut() }
     }
 }

uefi/src/proto/ata/pass_thru.rs

@@ -105,7 +105,7 @@ pub struct AtaDevice<'a> {
 }
 
 impl AtaDevice<'_> {
-    fn proto_mut(&mut self) -> *mut AtaPassThruProtocol {
+    const fn proto_mut(&mut self) -> *mut AtaPassThruProtocol {
         ptr::from_ref(self.proto).cast_mut()
     }
 

uefi/src/proto/console/gop.rs

@@ -569,7 +569,7 @@ impl FrameBuffer<'_> {
     ///
     /// On some implementations this framebuffer pointer can be used after
     /// exiting boot services, but that is not guaranteed by the UEFI Specification.
-    pub fn as_mut_ptr(&mut self) -> *mut u8 {
+    pub const fn as_mut_ptr(&mut self) -> *mut u8 {
         self.base
     }
 

uefi/src/proto/console/text/output.rs

@@ -72,7 +72,7 @@ impl Output {
 
     /// Returns an iterator of all supported text modes.
     // TODO: Bring back impl Trait once the story around bounds improves
-    pub fn modes(&mut self) -> OutputModeIter<'_> {
+    pub const fn modes(&mut self) -> OutputModeIter<'_> {
         let max = self.data().max_mode as usize;
         OutputModeIter {
             output: self,

uefi/src/proto/device_path/build.rs

@@ -79,7 +79,7 @@ pub struct DevicePathBuilder<'a> {
 
 impl<'a> DevicePathBuilder<'a> {
     /// Create a builder backed by a statically-sized buffer.
-    pub fn with_buf(buf: &'a mut [MaybeUninit<u8>]) -> Self {
+    pub const fn with_buf(buf: &'a mut [MaybeUninit<u8>]) -> Self {
         Self {
             storage: BuilderStorage::Buf { buf, offset: 0 },
         }

uefi/src/proto/loaded_image.rs

@@ -131,7 +131,7 @@ impl LoadedImage {
     /// long enough.
     ///
     /// [shim]: https://github.com/rhboot/shim/blob/4d64389c6c941d21548b06423b8131c872e3c3c7/pe.c#L1143
-    pub unsafe fn set_image(&mut self, data: *const c_void, size: u64) {
+    pub const unsafe fn set_image(&mut self, data: *const c_void, size: u64) {
         self.0.image_base = data;
         self.0.image_size = size;
     }
@@ -167,7 +167,7 @@ impl LoadedImage {
     /// must ensure that the memory lives long enough.
     ///
     /// [`boot::start_image`]: crate::boot::start_image
-    pub unsafe fn set_load_options(&mut self, options: *const u8, size: u32) {
+    pub const unsafe fn set_load_options(&mut self, options: *const u8, size: u32) {
         self.0.load_options = options.cast();
         self.0.load_options_size = size;
     }

uefi/src/proto/network/mod.rs

@@ -58,7 +58,7 @@ impl IpAddress {
     }
 
     #[must_use]
-    fn as_raw_ptr_mut(&mut self) -> *mut uefi_raw::IpAddress {
+    const fn as_raw_ptr_mut(&mut self) -> *mut uefi_raw::IpAddress {
         // The uefi-raw type is defined differently, but the layout is
         // compatible.
         self.0.as_mut_ptr().cast()

uefi/src/proto/nvme/pass_thru.rs

@@ -119,7 +119,7 @@ pub struct NvmeNamespace<'a> {
 }
 
 impl NvmeNamespace<'_> {
-    fn proto_mut(&mut self) -> *mut NvmExpressPassThruProtocol {
+    const fn proto_mut(&mut self) -> *mut NvmExpressPassThruProtocol {
         ptr::from_ref(self.proto).cast_mut()
     }
 

uefi/src/proto/scsi/pass_thru.rs

@@ -130,7 +130,7 @@ pub struct ScsiDevice<'a> {
     target_lun: ScsiTargetLun,
 }
 impl ScsiDevice<'_> {
-    fn proto_mut(&mut self) -> *mut ExtScsiPassThruProtocol {
+    const fn proto_mut(&mut self) -> *mut ExtScsiPassThruProtocol {
         ptr::from_ref(self.proto).cast_mut()
     }